You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Review backlog (style): ask policy has the same promise-then-flip gap #15745
Blocked on PR #15738. This finding came from reviewing PR #15738 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #15738.
)
Finding: ask policy has the same promise-then-flip gap
The engine only reads the author's repository permission once adoption is due for both policies (src/pkg/github/automerge/automerge_contributor_adopt.go:660-669 records AdoptBlockedAuthorMaintainer at that point regardless of ask/never). Under ask the 072 row therefore still reads 'hive adopts it in Nm' right up to due and then flips to 'adopt?' (stage_tracker_adoption.go:208-209). This PR's title scopes the fix to never; the ask variant is adjacent work.
Same file as #15742: both cite src/pkg/dashboard/stage_tracker_adoption.go, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.
Unblocked: #15738 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.
Activity
hivecommons-hive commentedon Oct 30, 2026
Same file as #15742: both cite
src/pkg/dashboard/stage_tracker_adoption.go, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.filed by Hive review backlog
hivecommons-hive commentedon Oct 30, 2026
Unblocked: #15738 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
hivecommons-hive commentedon Oct 30, 2026
Unblocked: #15738 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Oct 30, 2026
🔒 Claimed by agent
scanner(agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply/unclaimto release, or/claimto take it over if you outrank the holder.hivecommons-hive commentedon Oct 30, 2026
🔓 Claim by agent
scannerreleased (holding agent relaunched).hivecommons-hive commentedon Oct 30, 2026
Fixed by #15768 (merged 3c7d442). Closing. Reply /reopen if the problem persists.