Skip to content

🐛 [reviewer] PR stays at 070 Fixing for hours after the fixer exhausted its attempts #15744

Closed

Description

@clubanderson

What happened

Hive-authored PR #15308 (XXL, adopted from #15226 for #15198) sat at stage/070-fixing for 13h with the tracker reading "Fixing · @hivecommons-hive[bot]" — while nobody was fixing it.

Spoke logs, every ~5 min cycle:

WARN review fix dispatch excluded repo=hivecommons/hive pr=15308 head_sha=5b62304… author=hivecommons-hive[bot] reason=fix-attempts-exhausted attempts=6
automerge skip reason=human-changes-requested

The PR is also CONFLICTING with v5. The fix dispatcher excludes it (fix-attempts-exhausted, cap = 6 re-engagements), automerge skips it, yet the stage engine keeps it on 070 and the dashboard says the hive is on it. Worse, stage/stalled was removed:

stage labels reconciled … removed:["stage/stalled"] reason:"contributor-lane:decision-answered"

— a stale answered decision on a head that has not moved re-cleared the stall signal.

Expected

  1. When the fix dispatcher excludes a PR with fix-attempts-exhausted, the stage engine moves it from 070 to 085 Needs decision with caption fixer gave up after N attempts — <reviewer summary first line> and posts one decision comment per head (options: re-author from scratch, hand to a person, close as not planned). Tracker lead action: Re-author (decide:re-author); "Close as not planned" lives in the Decide… submenu. Write-back gating respected.
  2. The 070 caption never claims the hive is fixing when no fix job is dispatched/active: it says why the fixer is excluded (exhausted / conflicting / no fixer).
  3. A stale decision-answered must not clear stage/stalled / flip the stage when the head has not moved and the fixer is excluded.
  4. The review fix dispatch excluded WARN logs once per (pr, head), not every cycle.

Metadata

Metadata

Assignees

No one assigned

    Labels

    has-open-prhelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions