You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Review backlog (security): Carried approvals are accepted by the hold guard (previous finding re-checked: present but not exploitable) #15698
Blocked on PR #15645. This finding came from reviewing PR #15645 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #15645.
)
Finding: Carried approvals are accepted by the hold guard (previous finding re-checked: present but not exploitable)
holdGuardOperatorApproval accepts any Kind=approve record keyed to the current head, including records written by carryAdmissionToCopy (automerge_operator_admission.go:115-123) onto a hive copy's head the approver never viewed. Exploitability is negligible: the carry is written once at copy creation on the copy's first head (automerge_contributor_adopt.go:979) and the guard only reads the ledger on the drift path after the head-unchanged clear (main_helpers.go:180-185), so lifting via a carried record requires the branch to be force-pushed back to its creation SHA. Hardening: exclude bodies prefixed 'approve (carried'.
Same file as #15665: both cite src/cmd/hive/main_helpers.go, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.
🔒 Claimed by @mendezr (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.
Unblocked: #15645 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
Activity
hivecommons-hive commentedon Oct 30, 2026
Same file as #15665: both cite
src/cmd/hive/main_helpers.go, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.filed by Hive review backlog
hivecommons-hive commentedon Oct 30, 2026
Unblocked: #15645 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Oct 30, 2026
🔒 Claimed by @mendezr (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply
/unclaimto release, or/claimto take it over if you outrank the holder.hivecommons-hive commentedon Oct 30, 2026
🔓 Claim by @mendezr released (lease revoked).
hivecommons-hive commentedon Oct 30, 2026
Unblocked: #15645 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
🐛 fix: reject carried approvals in the hold guard
🐛 fix: reject carried approvals in the hold guard (#15893)