Skip to content

Review backlog (security): Carried approvals are accepted by the hold guard (previous finding re-checked: present but not exploitable) #15698

Closed

Description

@hivecommons-hive

Blocked on PR #15645. This finding came from reviewing PR #15645 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #15645.

PR: #15645 (#15645)
Perspective: security
Severity: low (P3)
Evidence: src/cmd/hive/main_helpers.go:66 (

if !ok || !req.IsApproval() || !strings.EqualFold(strings.TrimSpace(req.HeadSHA), headSHA) {
)
Finding: Carried approvals are accepted by the hold guard (previous finding re-checked: present but not exploitable)

holdGuardOperatorApproval accepts any Kind=approve record keyed to the current head, including records written by carryAdmissionToCopy (automerge_operator_admission.go:115-123) onto a hive copy's head the approver never viewed. Exploitability is negligible: the carry is written once at copy creation on the copy's first head (automerge_contributor_adopt.go:979) and the guard only reads the ledger on the drift path after the head-unchanged clear (main_helpers.go:180-185), so lifting via a carried record requires the branch to be force-pushed back to its creation SHA. Hardening: exclude bodies prefixed 'approve (carried'.

Fingerprint: 9515c54b4f35a5a9c392dfcd02d40c15828ba5461c4ad4c1ebe440cafc65953d

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 30, 2026
  2. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Same file as #15665: both cite src/cmd/hive/main_helpers.go, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.

    filed by Hive review backlog

  3. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 30, 2026
  4. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 30, 2026
  5. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15645 is no longer open. This issue is actionable again.

  6. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by @mendezr (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  7. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 30, 2026
  8. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @mendezr released (lease revoked).

  9. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15645 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions