Skip to content

Review backlog (correctness): maintainer_policy=never rows read 'hive adopts it in Nm' until the due moment #15692

Closed

Description

@hivecommons-hive

Blocked on PR #15662. This finding came from reviewing PR #15662 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #15662.

PR: #15662 (#15662)
Perspective: correctness
Severity: low (P3)
Evidence: src/pkg/dashboard/stage_tracker_adoption.go:171 (

} else if v := stageTrackerAutoAdoption(it, rec, hasRec, presence, clock, now); v.Running {
)
Finding: maintainer_policy=never rows read 'hive adopts it in Nm' until the due moment

rec.AdoptionBlocked(head)=author-is-maintainer is only recorded by the sweep after adoptionDue fires (automerge_contributor_adopt.go:657-662), so stageTrackerAdoption's else-branch (stage_tracker_adoption.go:171-173) projects an auto-adopt countdown for a maintainer-authored PR under policy never, which then flips to 'not adopted: maintainer_policy is never' at due. Cosmetic inconsistency; follow-up candidate.

Fingerprint: 6e82442a37b7909f86c9d2f8270e7dfd8b3735f8761a2062d772c8d11756f0be

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 30, 2026
  2. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Same file as #15665: both cite src/pkg/dashboard/stage_tracker_adoption.go, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.

    filed by Hive review backlog

  3. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 30, 2026
  4. removed
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 30, 2026
  5. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15662 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.

  6. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  7. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Verified still applies on v5, but not fixed in this sweep: the dashboard has no maintainer signal before the sweep records AdoptBlocked (authorMaintainsRepo needs a live GitHub permission read in the engine), so suppressing the countdown would need new plumbing into the tracker. Left open for a design decision.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: c0f02a7ba

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

  8. 8 remaining items

  9. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Good first issue — superseded: hosted-available-oke-11-placeholder-r05x started working on this issue itself (claimed-by-hive, 2026-10-30T12:59:05Z), so the good first issue label has been removed. Thanks for looking! Other issues open to new contributors are listed on the relay page: https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute

  10. added
    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.
    on Oct 30, 2026
  11. added
    stage/020-claimedClaimed by the scanner or a relay contributor
    and removed
    stage/010-actionableTriaged; eligible for the hive to pick up
    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.
    on Oct 30, 2026
  12. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions