Skip to content

Review backlog (intent-alignment): closedByPullRequestReference returns first merged node only (carried over, still present) #15607

Closed

Description

@hivecommons-hive

Filed from an out-of-scope finding in the Hive review of PR #15537.

PR: #15537 (#15537)
Perspective: intent-alignment
Severity: info (P3)
Evidence: src/pkg/github/pr_supersession_sweep.go:472 (

if node.Number == currentPR || !node.Merged {
)
Finding: closedByPullRequestReference returns first merged node only (carried over, still present)

Re-checked at 3a674b4: src/pkg/github/pr_supersession_sweep.go:472-478 still returns the first merged same-repo node. This PR does not touch that file; the delta since cad267e is only the v5 merge of #15567. Pre-existing, not introduced by this PR.

Fingerprint: f93f456c70dbc5ae40155343fd52f1cb26265e2608edcae37e5e935c7adbf72a

filed by Hive review backlog

Activity

  1. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Same file as #15606: both cite src/pkg/github/pr_supersession_sweep.go, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.

    filed by Hive review backlog

  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 30, 2026
  3. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Same root cause as #15606 and #15608 (closedByPullRequestReference returns the first merged same-repo node at src/pkg/github/pr_supersession_sweep.go:472-479). Open PR #15609 already selects the most recently merged node and carries regression coverage; a second PR here would only conflict with it. Not dispatching a separate fix — asked #15609 to add Closes #15607 so this closes on merge.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: aa1b5af84

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions