You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
adoption: a superseded PR stays open and listed beside hive's copy (needs-opt-in-label refuses the close) #15586
Seen (Activity Monitor, hive's spoke, 20:04 EDT): issue #15511 lists two PRs — hive's adoption #15574 ("adopted from @odttlnt's #15526", Merge queued · 2nd) and the original #15526 as a greyed sub-row "Adopted → #15574 · superseded (hive re-authored with sign-off)".
Owner: "if a PR is superseded it should be closed and not listed — no?"
Why
The close-first pass asked the write-back gate to close 🌱 dashboard: split stage_tracker.go into 4 files #15526 and was refused with needs-opt-in-label ("🌱 dashboard: split stage_tracker.go into 4 files #15526 carries none of hive-review; contributor_adopt needs the label at L6"). The contributor_adopt kind treats every non-hive-authored PR alike, so a clanker's PR the hive just re-authored (same commits, same sign-off) sits open until the copy merges, exactly like a person's.
An agent-authored (clanker/hive) original closes in the adopting pass by policy, without the repo opt-in label, once the copy carries its commits. New governor.labels.stage.adoption.close_superseded: on_adopt|on_merge (default on_adopt). Human-authored originals keep "close when the copy merges" unless the opt-in label is present.
A PR whose superseder is open and listed is not a row of its own: it lives only in the copy's "adopted from @x's #N" chip (hover: superseded, closes when the copy merges / closed). Ratchet: no item with superseded_by pointing at a rendered open PR appears as a row.
Activity