Skip to content

Activity monitor: adoption pair {original, hive copy} offered "Let hive decide — all 2 PRs" and a concatenated caption #15549

Closed

Description

@clubanderson

What happened

At 22:29Z the tracker showed #15495 and #15500 with an inline "Let hive decide — all 2 PRs" button, i.e. parked as needing a human decision. Each issue's two PRs were a contributor's PR (@mendezr's #15508 / #15507) and the hive's own adoption copy of it (#15537 / #15538). Captions read:

fell back to Covered by pr — Covered by PR #15537 — Review swarm requested; waiting for a verdict on the current head — review gate: no review bundle — waiting for a free reviewer for 1 cycle since 22:21 UTC; PR #15508 — Hive adopted this PR; hive is addressing the review findings (superseded by #15537) — changes requested

Owner's question: why didn't hive figure this out on its own?

Root cause

Hive did handle it: it adopted both PRs (contributor offline, fork not editable), opened #15537/#15538 with sign-off and Fixes #N, and marked the originals superseded. The write-back gate (needs-opt-in-label) stopped it from closing the originals ("close-first adoption suppressed by the write-back gate; original left open on the keep-open path"), so each issue listed two open PRs.

  1. The SPA's stageTrackerLinkedPROpen only excludes lp.superseded, which the server never sets (it sends adopted_by / lineage instead). So an open original with adopted_by counted as a competing PR → stageTrackerNestedOpenPRs().length == 2 → decide:delegate-all lead button.
  2. stageTrackerLinkedPRProgress (Go) joined every linked PR into the issue caption, so the superseded original's "changes requested" reached the issue.
  3. The "fell back to Covered by pr — " prefix is the client feed line (stageTrackerEventText): the issue had been mirroring the copy's stage 50 (stageTrackerFollowAdoption); when hive re-pointed the claim to the copy it dropped to its own 040, and the stage name was humanised from the slug rather than the table's short word.
  4. 🐛 fix: keep merge queue position visible during sweeps #15499 shows "no linked issue" because its original 🐛 fix: keep merge queue position visible during sweeps #15400 only had Refs #15395 — partial; adoptionCloses carried only bare Refs #N lines.

Clicking "Let hive decide" closed the originals as superseded (rule prefer-contributor, with credit) and sent the copies a "make CI green" direction — harmless, but the copies then read "a maintainer requested changes".

Fix

Treat an adoption pair as one logical PR in the caption, the open/parked/sibling counts and the delegate-all fan-out; prefer the stage table's word in the feed and read un-mirroring as "moved to"; carry annotated Refs lines into the copy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions