Skip to content

Review backlog (correctness): Link memo keyed by issue only while result depends on per-row exclude (currently a no-op) #15495

Closed

Description

@hivecommons-hive

Blocked on PR #15480. This finding came from reviewing PR #15480 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #15480.

PR: #15480 (#15480)
Perspective: correctness
Severity: info (P3)
Evidence: src/pkg/dashboard/stage_tracker.go:2974 (

facts, err := s.deps.GHClient.IssueLinkState(ctx, owner, name, li.Number, pr.Number)
)
Finding: Link memo keyed by issue only while result depends on per-row exclude (currently a no-op)

IssueLinkState(ctx, owner, name, li.Number, pr.Number) excludes the carrying PR, but the result is memoised under owner/repo#issue (stage_tracker.go:2970-2978) and reused for other rows. Harmless today: Items only lists open PRs (stage_tracker.go:85) and closedByPullRequestReference is merged-only (pr_supersession_sweep.go:473), so the exclusion never removes a candidate. Would silently drop the closer for sibling rows if merged PRs ever become tracker rows.

Fingerprint: ddb05373f1509215c5803e68671f6664699157ee0bcf7ab3a9cd3c999ee76edc

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 29, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 29, 2026
  3. removed
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 29, 2026
  4. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15480 is no longer open. This issue is actionable again.

  5. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by @mendezr (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  6. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @mendezr released (lease revoked).

  7. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15480 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions