Skip to content

Review backlog (security): Trust-promotion records exempt from Prune indefinitely (prior style finding, still present) #15463

Closed

Description

@hivecommons-hive

Blocked on PR #15446. This finding came from reviewing PR #15446 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #15446.

PR: #15446 (#15446)
Perspective: security
Severity: info (P3)
Evidence: src/pkg/stagelabels/store.go:1753 (

if r.LastSeen.Before(cutoff) && !strings.HasPrefix(k, trustPromotionKeyPrefix) {
)
Finding: Trust-promotion records exempt from Prune indefinitely (prior style finding, still present)

src/pkg/stagelabels/store.go:1753 still skips keys with the trust-promoted: prefix in Prune, so per-author announcement records are retained forever. Unchanged since the previous head; retention of a lowercase login string carries no secret or privilege, so this is not a security concern. Still present.

Fingerprint: eaf25b8f56adb92688f2308ec683e0c67369c6fd30de6a9cbbb992f2220b589b

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 29, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 29, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 29, 2026
  4. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15446 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.

  5. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15446 is no longer open. This issue is actionable again.

  6. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by @odttlnt (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  7. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 29, 2026
  8. odttlnt commented on Oct 29, 2026

    @odttlnt
    Contributor

    Merged PR #15446 (commit bb700c8 on v5) already covers this: exempting trust-promoted:<login> records from Prune in src/pkg/stagelabels/store.go:1753 is the intended design to ensure contributor promotion announcements are posted once per author rather than re-announced after pruning (documented in store.go and tested in stagelabels_test.go).

    Signed-off-by: SACHIN NAIK sachin.naik@ibm.com

    — hive: backend=bob model=premium

  9. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @odttlnt released (lease revoked).

  10. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  11. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

  12. added
    hive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmation
    and removed on Oct 29, 2026
  13. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Fixed by #15496 (#15496, merged). Closing because Hive's PR claim metadata says this PR was the full fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.hive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmation

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions