Skip to content

Tracker: Close (read) on an advisory does nothing visible — no progress, item stays, issue stays open #15436

Closed

Description

@clubanderson

What happened

Owner clicked Close (read) on the advisory row for #15381 (~17:10Z, hive's hive on v5 `e0f8bd901`, includes #15418):

"i clicked close and it still shows in list. I should see some progress (consistent with tracker) until the item is closed and is out of the list also"

Result: the issue is still OPEN, no comment, the row is unchanged, and nothing in the pod says anything happened.

Evidence

  • `/api/stage-tracker` row for triage: duplicate and overlapping open issues/PRs to consolidate #15381: `"history": []` — the operator-action ledger never saw a request.
  • `/api/audit` has no `repo-item-decision-close` for 15381; pod logs (`--since=6h`, grep `15381|close-read|decision`) show only poller lines.
  • Code: `runRowAction` routes every `decide:*` id through `stageTrackerDecisionTarget(it)`, which only returns a target for a parked PR / an issue carrying `needs-decision` (or stage 45). An advisory row is `stage 0` with no modifier → the target list is empty → `runRowAction` returns `{toasts: [], pending: []}` without a request, a toast or any busy state. The confirm dialog never even opens.

The server side (`handleRepoItemDecision` → `close-read` → comment + `CloseIssue(completed)`) works when reached (unit-tested in #15418); the SPA never reaches it.

Expected

  1. Close (read) acts on the advisory row itself and really closes the issue (comment "Closed as read (advisory acknowledged) by @operator from the Hive dashboard", close as completed), refusing with a visible reason on a paused repo.
  2. Any mutating row action (close-read, close-superseded, won't-fix, hold, approve/merge, decide) shows progress on the chevron the moment it is clicked — the existing striped busy state with a verb caption ("Closing…"), then a terminal caption ("Closed · leaving list") — and the row leaves the list on the next tracker poll. The server marks the item as operator-closed so the next snapshot cannot resurrect the row before GitHub's list catches up.
  3. A failure (refused, GitHub 4xx/5xx, network) restores the chevron and says exactly why in a toast and on the row's history badge — never silent.

Activity

  1. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    Contributor

    🔒 Claimed by @onkar717 (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 29, 2026
  3. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    Contributor

    🔓 Claim by @onkar717 released (released on disconnect).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions