Skip to content

Review backlog (intent-alignment): Grounding budget wording predates fan-out #15435

Closed

Description

@hivecommons-hive

Blocked on PR #15431. This finding came from reviewing PR #15431 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #15431.

PR: #15431 (#15431)
Perspective: intent-alignment
Severity: info (P3)
Evidence: src/pkg/review/prompts.go:697 (

b.WriteString(groundingSectionWithBudget(pr, combinedGroundingBudget(len(perspectives)), fmt.Sprintf("this whole review, across all %d perspectives", len(perspectives))))
)
Finding: Grounding budget wording predates fan-out

BuildCombinedPrompt still emits groundingSectionWithBudget(..., "this whole review, across all N perspectives") as one shared budget; with the new fan-out each sub-agent receives the shared instructions and may read the whole budget as its own, so total tool calls per head kick can exceed the stated cap. Does not affect whether this PR does what its title/body claim; a follow-up could add a per-sub-agent split to buildHeadFanOutInstruction.

Fingerprint: 615f138004548ebb49d9afedfd41aa5cf74b793ec383586c0d285c49d446e80c

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 29, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 29, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 29, 2026
  4. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15539 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.

  5. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15539 (superseding #15431) is no longer open. This issue is actionable again.

  6. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by @odttlnt (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  7. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 29, 2026
  8. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @odttlnt released (lease revoked).

  9. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Additional finding (folded in — same finding area and category). Raised in the Hive review of PR #15564 (#15564) and folded into this issue because it is a intent-alignment finding at the same symbol or lines of src/pkg/review/prompts.go as this issue. Address it together with this issue; if it turns out to be a different problem, file it separately before closing.

    Review backlog (intent-alignment): Head's own reads not reserved from the split budget (carried, advisory)

    • Head's own reads not reserved from the split budget (carried, advisory) (src/pkg/review/prompts.go:746)

    Perspective: intent-alignment
    Severity: info (P3)
    Evidence: src/pkg/review/prompts.go:746 (

    fmt.Fprintf(&b, " Grounding budget: the shared %d tool calls cover this whole review, not each sub-agent. Tell each sub-agent it may make at most %d investigation tool calls for its own perspective, so the total across all %d stays within the cap.\n", combinedGroundingBudget(len(perspectives)), fanOutSubAgentBudget(len(perspectives)), len(perspectives))
    )
    Finding: Head's own reads not reserved from the split budget (carried, advisory)

    Unchanged since the previous review at 7629a36. src/pkg/review/prompts.go:746 gives sub-agents combinedGroundingBudget(n)/n each, so the n sub-agents collectively consume the whole cap while the head's own step-1 reads (prompts.go:743: fetch metadata, diff, linked issue) are extra. Total can exceed the stated cap by the head's few fixed reads. Does not affect whether the PR satisfies #15435, which only asked for the per-sub-agent split; a follow-up could subtract a small head reserve before dividing.

    Fingerprint: e7ba4c8ba90edbe7454a81763f46758315b3033b51b0c98de2f178f8b6986bd6

    filed by Hive review backlog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthas-open-prhelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions