Skip to content

Review backlog (security): Author-by-login path trusts GitHub email→login resolution, spoofable via bot noreply address #15421

Closed

Description

@hivecommons-hive

Blocked on PR #15405. This finding came from reviewing PR #15405 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #15405.

PR: #15405 (#15405)
Perspective: security
Severity: low (P3)
Evidence: src/pkg/github/pr_merge_state.go:127 (

return authorLogin != "" && c.hiveCommitIdentity(authorLogin, rc.GetCommit().GetAuthor().GetEmail()), nil
)
Finding: Author-by-login path trusts GitHub email→login resolution, spoofable via bot noreply address

CommitByHive accepts the author when GitHub resolves author.login to the App bot, regardless of signature verification (codified by test 'bot login author, web-flow committer, unverified → true'). GitHub derives author.login from the commit's free-text author email, so a pusher setting user.email to the App's ID+name[bot]@users.noreply.github.com address gets the bot login resolved and passes CommitByHive on an unsigned commit. Pre-existing at merge-base (pr_merge_state.go:110-113), not widened by this PR; backlog: require verified or a web-flow/bot committer on the author path.

Fingerprint: 4c2baa688ea7cfe19feb5fef7ca7b878d7059dfad5deaa6e2b3f0f93cba00f7c

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 29, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 29, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 29, 2026
  4. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15405 is no longer open. This issue is actionable again.

  5. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 30, 2026
  6. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  7. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15405 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions