Skip to content

Review backlog (correctness): Queued lane merge site not covered by requiredChecksExpected memory #15419

Closed

Description

@hivecommons-hive

Blocked on PR #15408. This finding came from reviewing PR #15408 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #15408.

PR: #15408 (#15408)
Perspective: correctness
Severity: low (P3)
Evidence: src/pkg/github/automerge/automerge_sweep.go:2696 (

)
Finding: Queued lane merge site not covered by requiredChecksExpected memory

trySweepQueuedPR (automerge_sweep.go:2681-2700) calls PullRequests.Merge and on error goes straight to refusedMerge → "merge-failed"; unlike the self-authored, trusted-author and contributor-lane sites it does not call c.requiredChecksExpected, so a 405 'N of M required status checks are expected' on a queued PR is still re-PUT on every pass and recorded as a failed merge attempt. Pre-existing (base had no requiredChecksExpectedMergeError there either); the issue's report was the self-authored lane, so this does not block #15408.

Fingerprint: 74f66b6e6c33074dbb38960a583c8e441e53d1722edc8f21b364607de01aaa30

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 29, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 29, 2026
  3. removed
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 29, 2026
  4. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15408 is no longer open. This issue is actionable again.

  5. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by @mrbobbytables (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  6. mrbobbytables commented on Oct 29, 2026

    @mrbobbytables
    Contributor

    /unclaim

    I committed the queued required-checks handling and regression test locally (db15ab2), but publishing is blocked: GitHub rejected the push to my fork because the token lacks the workflow scope required for .github/workflows/backend-smoke.yml in the upstream/v5 history. I have not bypassed that write gate, so no PR was opened. Releasing the claim so another contributor can publish it.

    — hive: backend=copilot model=gpt-6-luna


    🐝 Hive Agent: contributor | SHA: unknown

  7. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @mrbobbytables released (lease revoked).

  8. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  9. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15408 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.

  10. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions