Skip to content

dashboard: "Let hive decide — preview" is a wall of text (doubled "Hive would", contradictory merge button, no hierarchy) #15397

Closed

Description

@clubanderson

Operator feedback

Screenshot of the "Let hive decide — preview" dialog on hive's own spoke, for #15332:

yikes - this is a mess. different fonts, repeated wording, placement of text and buttons, explanation is confusing.

and, after a first pass:

this needs to be exceedingly simple to understand and act on.

What the dialog showed

Let hive decide — preview
⚠ hivecommons/hive#15332 — Sentinel flagged security-relevant changes at 7af26e9: changes 1 sensitive path(s)
hivecommons/hive#15332 — Hive would: Hive would: send #15332 back with direction: make CI green without widening scope; keep the smallest reversible change, then it merges. Why: The head is not mergeable yet; the direction names the fix and nothing else.
 • hive posts the direction on #15332
 • the author's clanker pushes a new commit; the row moves when it lands
It records a "/hive decision" (or a recommendation when the question is the hive's own policy), lifts the park and stamps an audit marker. Rails: it never merges, never acts on a held item, never grants secrets or permissions, and leaves the sentinel label to a person.
[Cancel] [Approve & merge as-is] [Let hive do that]

Problems

  1. "Hive would: Hive would:" — the prefix is composed twice (the plan API's summary already carries it and stageTrackerDelegatePlanText prepends it again).
  2. repo#number repeated on two lines.
  3. Three type sizes/colours with no hierarchy; the "then" bullets are inlined into a paragraph.
  4. The rails footer is boilerplate that drowns the one decision that matters.
  5. "Approve & merge as-is" is offered although the preview itself says the head is not mergeable — a contradictory action. It must be hidden (or disabled with a reason) when the ladder (🐛 Let hive decide: close already-fixed PRs instead of adopting them #15301 decision.ladder) / head facts rule out mergeable-as-is.
  6. Button placement/alignment is inconsistent with the other hive dialogs (.hive-dialog-btn family).

Target

Readable in 3 seconds: title + one subject line; one verb-first decision sentence in plain words; one why line (≤ 12 words); at most two "then" items; everything else (rails, ruled-out rungs, sentinel detail) behind a single collapsed Details. Exactly two buttons by default — [Cancel] [Let hive do that] — a third only when the item is mergeable as-is. No jargon in the visible text (no "park", "audit marker", "stage", "ladder", "/hive decision"). Visible text ≤ 60 words for the #15332 case, enforced by a test. One renderer shared by PR, issue and the adopt/close/return variants from #15301.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    has-open-prhelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions