Skip to content

Review backlog (correctness): Gateway-status exclusion is attr-only; IsBenignMessage still lacks the whole-line equivalent #15369

Closed

Description

@hivecommons-hive

Blocked on PR #15366. This finding came from reviewing PR #15366 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #15366.

PR: #15366 (#15366)
Perspective: correctness
Severity: low (P3)
Evidence: src/pkg/fleetreport/fleetreport.go:856 (

// (IsGitHubRateLimited), every benignSubstrings entry, and the
)
Finding: Gateway-status exclusion is attr-only; IsBenignMessage still lacks the whole-line equivalent

IsBenignMessage applies IsGitHubRateLimited to the whole message text (comment at fleetreport.go:853-856), but the new IsGitHubUpstreamUnavailable is only wired into the slog error attr path (slogfeed.go:104, 168-178). A call site that formats the go-github error into the message string (not an attr) with ': 503 ' would still be counted as unclassified_error_repeated, unlike the rate-limit case. The #15365 line is attr-based, so this does not affect the contract; adjacent gap for later.

Fingerprint: 0d1e943807d14856f0755abf6d033a06b87b168f93c1f049723dfde9c04a19f2

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 29, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 29, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 29, 2026
  4. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15366 is no longer open. This issue is actionable again.

  5. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by @Karibhou (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  6. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 29, 2026
  7. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @Karibhou released (lease revoked).

  8. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15366 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions