Skip to content

Review backlog (correctness): Previous security finding unchanged (workflow not touched by delta) #15340

Closed

Description

@hivecommons-hive

Blocked on PR #15332. .github/workflows/crux-file-size-ratchet.yml does not exist on v5; this finding tracks code the PR introduces, so there is nothing to ship until it lands. The hive lifts the blocked label when the PR merges or closes.

Filed from an out-of-scope finding in the Hive review of PR #15332.

PR: #15332 (#15332)
Perspective: correctness
Severity: info (P3)
Evidence: .github/workflows/crux-file-size-ratchet.yml:48 (

run: bash "$GITHUB_WORKSPACE/crux-ratchet/.github/scripts/check-file-size-ratchet.sh" "$GITHUB_WORKSPACE/crux-ratchet/.github/go-file-size-ratchet.txt"
)
Finding: Previous security finding unchanged (workflow not touched by delta)

The delta does not touch .github/workflows/crux-file-size-ratchet.yml; the step at line 48 still runs a script fetched from crux main at run time. This is the security perspective's call, not a correctness defect; noted here only as re-check status: still present.

Fingerprint: 75d904149896f839bc79b4ea92672174296a92e414609aa49782d2ab2a0b5a0e

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 29, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 29, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 29, 2026
  4. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15332 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.

  5. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15332 is no longer open. This issue is actionable again.

  6. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by @Karibhou (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  7. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 29, 2026
  8. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @Karibhou released (lease revoked).

  9. github-actions commented on Oct 30, 2026

    @github-actions
    Contributor

    @hivecommons-hive[bot] this issue was closed by @clubanderson as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions