Skip to content

Review backlog (security): Third-party bot reply can suppress /lgtm + /approve posting (still present, fail-safe) #15263

Closed

Description

@hivecommons-hive

Blocked on PR #15216. This finding came from reviewing PR #15216 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #15216.

PR: #15216 (#15216)
Perspective: security
Severity: low (P3)
Evidence: src/pkg/github/pr_decision_operator.go:104 (

// hive command comment count.
)
Finding: Third-party bot reply can suppress /lgtm + /approve posting (still present, fail-safe)

prowRejectedHiveCommands treats any non-hive Bot-typed or [bot]-suffixed comment that contains a Prow rejection phrase and quotes a hive command comment id as proof the bot is not an approver. Humans cannot trigger it (covered by test 'human quoting the phrase'), but any other installed bot can. Consequence is limited to not posting the commands; the approval is still recorded and surfaced via CommandsSkipped/toast, so it is fail-safe.

Fingerprint: 0ad2ada50a841810c0225e55fa8974c64a2fec3eb3e21c2fa852eb1a18c5e404

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 29, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 29, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 29, 2026
  4. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15216 is no longer open. This issue is actionable again.

  5. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 29, 2026
  6. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  7. added
    stage/010-actionableTriaged; eligible for the hive to pick up
    and removed
    stage/020-claimedClaimed by the scanner or a relay contributor
    on Oct 29, 2026
  8. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15216 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.

  9. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

  10. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Additional finding (folded in — same finding area and category). Raised in the Hive review of PR #15645 (#15645) and folded into this issue because it is a security finding at the same symbol or lines of src/pkg/github/pr_decision_operator.go as this issue. Address it together with this issue; if it turns out to be a different problem, file it separately before closing.

    Review backlog (security): Approval record binds to live head at click time, not the head rendered to the operator

    • Approval record binds to live head at click time, not the head rendered to the operator (src/pkg/github/pr_decision_operator.go:386)

    Perspective: security
    Severity: info (P3)
    Evidence: src/pkg/github/pr_decision_operator.go:386 (

    )
    Finding: Approval record binds to live head at click time, not the head rendered to the operator

    RecordOperatorPullRequestApprovalWith reads the head via openPullRequestHeadLabels at call time; a push between dashboard render and click is approved unseen. Pre-existing writer behavior, and the guard's existing human-lift timeline path has the same exposure, so no regression — noted because the PR body states the record is 'against the exact head the person saw'.

    Fingerprint: bb592e55e9b282bbbd9bf90756251d659997504ebc66b1b65b14b1f70166c1aa

    filed by Hive review backlog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions