You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Blocked on PR #15216. This finding came from reviewing PR #15216 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #15216.
prowRejectedHiveCommands treats any non-hive Bot-typed or [bot]-suffixed comment that contains a Prow rejection phrase and quotes a hive command comment id as proof the bot is not an approver. Humans cannot trigger it (covered by test 'human quoting the phrase'), but any other installed bot can. Consequence is limited to not posting the commands; the approval is still recorded and surfaced via CommandsSkipped/toast, so it is fail-safe.
🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.
Unblocked: #15216 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.
Additional finding (folded in — same finding area and category). Raised in the Hive review of PR #15645 (#15645) and folded into this issue because it is a security finding at the same symbol or lines of src/pkg/github/pr_decision_operator.go as this issue. Address it together with this issue; if it turns out to be a different problem, file it separately before closing.
Review backlog (security): Approval record binds to live head at click time, not the head rendered to the operator
Approval record binds to live head at click time, not the head rendered to the operator (src/pkg/github/pr_decision_operator.go:386)
Perspective: security
Severity: info (P3)
Evidence: src/pkg/github/pr_decision_operator.go:386 (
)
Finding: Approval record binds to live head at click time, not the head rendered to the operator
RecordOperatorPullRequestApprovalWith reads the head via openPullRequestHeadLabels at call time; a push between dashboard render and click is approved unseen. Pre-existing writer behavior, and the guard's existing human-lift timeline path has the same exposure, so no regression — noted because the PR body states the record is 'against the exact head the person saw'.
Activity
hivecommons-hive commentedon Oct 29, 2026
Unblocked: #15216 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Oct 29, 2026
🔒 Claimed by agent
scanner(agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply/unclaimto release, or/claimto take it over if you outrank the holder.hivecommons-hive commentedon Oct 29, 2026
Unblocked: #15216 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.
hivecommons-hive commentedon Oct 29, 2026
🔓 Claim by agent
scannerreleased (holding agent relaunched).hivecommons-hive commentedon Oct 30, 2026
Additional finding (folded in — same finding area and category). Raised in the Hive review of PR #15645 (#15645) and folded into this issue because it is a security finding at the same symbol or lines of
src/pkg/github/pr_decision_operator.goas this issue. Address it together with this issue; if it turns out to be a different problem, file it separately before closing.Review backlog (security): Approval record binds to live head at click time, not the head rendered to the operator
src/pkg/github/pr_decision_operator.go:386)Perspective: security
Severity: info (P3)
Evidence:
src/pkg/github/pr_decision_operator.go:386(hive/src/pkg/github/pr_decision_operator.go
Line 386 in 5fc0756
Finding: Approval record binds to live head at click time, not the head rendered to the operator
RecordOperatorPullRequestApprovalWith reads the head via openPullRequestHeadLabels at call time; a push between dashboard render and click is approved unseen. Pre-existing writer behavior, and the guard's existing human-lift timeline path has the same exposure, so no regression — noted because the PR body states the record is 'against the exact head the person saw'.
Fingerprint:
bb592e55e9b282bbbd9bf90756251d659997504ebc66b1b65b14b1f70166c1aafiled by Hive review backlog