Skip to content

Review backlog (security): Sentinel release trusts any-author approval marker when hive identity is unknown (still present) #15262

Closed

Description

@hivecommons-hive

Blocked on PR #15216. This finding came from reviewing PR #15216 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #15216.

PR: #15216 (#15216)
Perspective: security
Severity: low (P3)
Evidence: src/pkg/github/sentinel_clearance.go:123 (

if comment == nil || !c.markerAuthorTrusted(comment.GetUser()) {
)
Finding: Sentinel release trusts any-author approval marker when hive identity is unknown (still present)

sentinelReleasedByDashboardApproval accepts a hive:pr-approval marker from any comment author whenever markerAuthorTrusted falls back to the legacy any-author rule (label_approval.go:436-441, knowsOwnAccounts()==false: no configured identity and GET /user unresolved). In that degraded config a PR author can forge the rendered /approve comment for their own head and release the sentinel alert. Same exposure already exists for the SentinelMarker path at sentinel_clearance.go:197, so not a regression; the forged-author test only covers the identity-known case. Suggested fix: require c.knowsOwnAccounts() && c.isHiveAccount(user) for this gate.

Fingerprint: d53fdb742b5e4bed276d81563e950dfdb64cf3ff162949abe0ad96c8bd6b6801

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 29, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 29, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 29, 2026
  4. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15216 is no longer open. This issue is actionable again.

  5. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  6. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 29, 2026
  7. added
    stage/010-actionableTriaged; eligible for the hive to pick up
    and removed
    stage/020-claimedClaimed by the scanner or a relay contributor
    on Oct 29, 2026
  8. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15216 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.

  9. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions