You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Review backlog (security): Sentinel release trusts any-author approval marker when hive identity is unknown (still present) #15262
Blocked on PR #15216. This finding came from reviewing PR #15216 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #15216.
)
Finding: Sentinel release trusts any-author approval marker when hive identity is unknown (still present)
sentinelReleasedByDashboardApproval accepts a hive:pr-approval marker from any comment author whenever markerAuthorTrusted falls back to the legacy any-author rule (label_approval.go:436-441, knowsOwnAccounts()==false: no configured identity and GET /user unresolved). In that degraded config a PR author can forge the rendered /approve comment for their own head and release the sentinel alert. Same exposure already exists for the SentinelMarker path at sentinel_clearance.go:197, so not a regression; the forged-author test only covers the identity-known case. Suggested fix: require c.knowsOwnAccounts() && c.isHiveAccount(user) for this gate.
🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.
Unblocked: #15216 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.
Activity
hivecommons-hive commentedon Oct 29, 2026
Unblocked: #15216 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Oct 29, 2026
🔒 Claimed by agent
scanner(agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply/unclaimto release, or/claimto take it over if you outrank the holder.hivecommons-hive commentedon Oct 29, 2026
Unblocked: #15216 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.
hivecommons-hive commentedon Oct 29, 2026
🔓 Claim by agent
scannerreleased (holding agent relaunched).