Skip to content

🐛 clanker PR with a human changes-requested review stays at Sentinel alert · needs human instead of Returned to contributor #15255

Closed

Description

@clubanderson

What happened

hive PR #15159 ("chore: remove unreachable MITM cancellation guard", authored by @thatguywob's clanker — author/clanker, role/trusted, base v5) touches .github/workflows/v2-ci.yml, so the sentinel flagged it and the contributor lane parked it at stage/085-needs-decision (contributor-lane:sentinel-blocked).

The owner (@clubanderson) posted a CHANGES_REQUESTED review ("drop the workflow change") and set stage/072-returned-to-contributor. The next sweep re-applied sentinel-alert + stage/085-needs-decision; the Activity Monitor row reads Sentinel alert · needs human even though a human has reviewed.

Recording a direction via POST /api/repos/{o}/{r}/items/15159/decision answered 409 the hive did not open this pull request, so it cannot carry a direction to its author; leave a changes-requested review instead — but the review had already been left and was being ignored.

Why

  • The contributor lane's prefilter returns sentinel-blocked before it ever reads reviews, so the human change request never reaches the stage detail/store for this PR.
  • ClassifyStage maps the needs-human reasons (sentinel, hold, workflow-path…) straight to 085 without consulting the standing human change request on the head, and RouteHuman has no human-change-requester input.
  • The dashboard decision path only accepts direction on hive-authored PRs.

Expected

  1. A trusted human's CHANGES_REQUESTED review on the current head of a clanker PR routes it to stage/072-returned-to-contributor (actor: the owning contributor), and that wins over the sentinel/085 park for that head; the park re-arms only on a new head (per head, consistent with 🐛 Sentinel: a dashboard Approve releases the head for good; skip Prow-rejected /lgtm + /approve #15216).
  2. direction decisions are accepted on clanker PRs: the text is posted to the contributor's hive as a change request and the PR goes to 072. The 409 stays only for a person's PR.
  3. The 071/072 chevron keeps its routing word (Returned to @thatguywob's hive · sentinel), with the sentinel finding as a suffix; Sentinel alert · needs human is 085 only.

Activity

  1. added a commit that references this issue on Oct 29, 2026
    7c02ec5
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 29, 2026
  3. added 2 commits that reference this issue on Oct 29, 2026
    6d80f59
    23a75d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions