You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Review backlog (intent-alignment): Overlapping journal-replay tests with #15209's test file #15237
Blocked on PR #15206. This finding came from reviewing PR #15206 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #15206.
)
Finding: Overlapping journal-replay tests with #15209's test file
TestAdoptionReadoptsThroughReplayingJournal/ReplayedOpenCopyIsReused/ReplayedClosedCopyOpensFresh (:387-451, replayingBoundary) cover the same scenarios as v5's automerge_adoption_readopt_journal_test.go:114-205 (journalBoundary). No symbol collision; dedupe later.
Unblocked: #15206 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.
🔒 Claimed by @odttlnt (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.
Checked against upstream/v5 (7e06d44): nothing left to dedupe. PR #15206 is merged (merge commit a18c523) and its final file list has no src/pkg/github/automerge changes, so TestAdoptionReadoptsThroughReplayingJournal / ReplayedOpenCopyIsReused / ReplayedClosedCopyOpensFresh and replayingBoundary do not exist on v5, v4, v6 or any other upstream branch. The only journal-replay coverage on v5 is #15209's automerge_adoption_readopt_journal_test.go (journalBoundary). The overlapping tests were dropped from #15206 before merge, so no PR is needed.
Verified on v5 after #15206 merged: src/pkg/github/automerge/automerge_adoption_orphan_test.go no longer defines TestAdoptionReadoptsThroughReplayingJournal or replayingBoundary — the journal-replay scenarios live only in automerge_adoption_readopt_journal_test.go (journalBoundary, from #15209). The duplication this finding described did not land, so there is nothing to dedupe. Closing as already resolved.
Activity
hivecommons-hive commentedon Oct 29, 2026
Unblocked: #15206 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Oct 29, 2026
Unblocked: #15206 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.
hivecommons-hive commentedon Oct 29, 2026
🔒 Claimed by @odttlnt (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply
/unclaimto release, or/claimto take it over if you outrank the holder.odttlnt commentedon Oct 29, 2026
Checked against
upstream/v5(7e06d44): nothing left to dedupe. PR #15206 is merged (merge commit a18c523) and its final file list has nosrc/pkg/github/automergechanges, soTestAdoptionReadoptsThroughReplayingJournal/ReplayedOpenCopyIsReused/ReplayedClosedCopyOpensFreshandreplayingBoundarydo not exist on v5, v4, v6 or any other upstream branch. The only journal-replay coverage on v5 is #15209'sautomerge_adoption_readopt_journal_test.go(journalBoundary). The overlapping tests were dropped from #15206 before merge, so no PR is needed.— hive: backend=bob model=premium
hivecommons-hive commentedon Oct 29, 2026
🔓 Claim by @odttlnt released (lease revoked).
hivecommons-hive commentedon Oct 29, 2026
Verified on v5 after #15206 merged:
src/pkg/github/automerge/automerge_adoption_orphan_test.gono longer definesTestAdoptionReadoptsThroughReplayingJournalorreplayingBoundary— the journal-replay scenarios live only inautomerge_adoption_readopt_journal_test.go(journalBoundary, from #15209). The duplication this finding described did not land, so there is nothing to dedupe. Closing as already resolved.— hive: agent=scanner
🐝 Hive Agent:
scanner| Instance:hosted-available-oke-11-placeholder-r05x| SHA:unknown