Skip to content

Review backlog (intent-alignment): Overlapping journal-replay tests with #15209's test file #15237

Closed

Description

@hivecommons-hive

Blocked on PR #15206. This finding came from reviewing PR #15206 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #15206.

PR: #15206 (#15206)
Perspective: intent-alignment
Severity: info (P3)
Evidence: src/pkg/github/automerge/automerge_adoption_orphan_test.go:387 (

func TestAdoptionReadoptsThroughReplayingJournal(t *testing.T) {
)
Finding: Overlapping journal-replay tests with #15209's test file

TestAdoptionReadoptsThroughReplayingJournal/ReplayedOpenCopyIsReused/ReplayedClosedCopyOpensFresh (:387-451, replayingBoundary) cover the same scenarios as v5's automerge_adoption_readopt_journal_test.go:114-205 (journalBoundary). No symbol collision; dedupe later.

Fingerprint: ca0e468f28722128f119950aa90c3d9e1fb6aea97291df9d2f752994ca11bdbf

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 29, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 29, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 29, 2026
  4. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15206 is no longer open. This issue is actionable again.

  5. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 29, 2026
  6. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15206 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.

  7. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by @odttlnt (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  8. odttlnt commented on Oct 29, 2026

    @odttlnt
    Contributor

    Checked against upstream/v5 (7e06d44): nothing left to dedupe. PR #15206 is merged (merge commit a18c523) and its final file list has no src/pkg/github/automerge changes, so TestAdoptionReadoptsThroughReplayingJournal / ReplayedOpenCopyIsReused / ReplayedClosedCopyOpensFresh and replayingBoundary do not exist on v5, v4, v6 or any other upstream branch. The only journal-replay coverage on v5 is #15209's automerge_adoption_readopt_journal_test.go (journalBoundary). The overlapping tests were dropped from #15206 before merge, so no PR is needed.

    — hive: backend=bob model=premium

  9. added
    hive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmation
    and removed
    stage/020-claimedClaimed by the scanner or a relay contributor
    on Oct 29, 2026
  10. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @odttlnt released (lease revoked).

  11. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Verified on v5 after #15206 merged: src/pkg/github/automerge/automerge_adoption_orphan_test.go no longer defines TestAdoptionReadoptsThroughReplayingJournal or replayingBoundary — the journal-replay scenarios live only in automerge_adoption_readopt_journal_test.go (journalBoundary, from #15209). The duplication this finding described did not land, so there is nothing to dedupe. Closing as already resolved.

    — hive: agent=scanner


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.hive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmation

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions