Skip to content

🐛 tracker: a PR whose linked issue was closed is promoted to the row head, leaving the issue column empty #15232

Closed

Description

@clubanderson

What happened

In the Activity Monitor stage tracker, PR #15191 ("Let hive decide on a ready-for-human-merge PR approves and lets the sweep merge it") draws as the row's primary item on the left, with a secondary chip closes #15173 · closed. Every other row puts the issue on the left and the PR on the right under the ↳ branch. The operator asked "why is this not having an issue listed?"

#15191's linked issue #15173 had been closed by a different merged PR (#15181).

In the same view the dibs #496 / #500 row keeps the closed issue #496 as the row head (strikethrough + closed chip) with PR #500 on the right.

Root cause

stageTrackerClosedIssueAnchor (#14655) deliberately re-anchors a standalone PR row on the PR when every closing-keyword link names a closed issue (closed_issue set), and the SPA's stageTrackerRowHtml then draws the PR at full width in the issue slot. A PR whose link is soft (Refs #N, title/mention) skips that anchor and goes through stageTrackerPRIssueSlot, which keeps the closed issue on the left with the strikethrough treatment. So the row head depends on how the PR links the issue, not on whether the issue is known — which reads as an inconsistency and hides the duplicate-fix situation.

Expected

  • A PR's linked issue (closing keyword or hive Fixes/Refs metadata) is always drawn in the issue (left) slot, open or closed, with the same strikethrough + closed chip as the soft-link case.
  • When the issue was closed by a different merged PR, the chip reads closed by #other so the operator sees the duplicate.
  • A PR with no known linked issue keeps standing on its own, as today.

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 29, 2026
  2. added a commit that references this issue on Oct 29, 2026
    faec60a
  3. github-actions commented on Oct 29, 2026

    @github-actions
    Contributor

    @clubanderson this issue was closed by @hivecommons-hive[bot] as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    has-open-prhelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions