You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Review backlog (correctness): replaySupersedeOntoBase claim is not keyed by prior_copy and is journal-replayed on re-adoption #15225
Blocked on PR #15209. This finding came from reviewing PR #15209 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #15209.
)
Finding: replaySupersedeOntoBase claim is not keyed by prior_copy and is journal-replayed on re-adoption
The branch_push claim in replaySupersedeOntoBase uses Inputs {pr, head_sha, base, reason} with no prior_copy (lines 950-951), so on a re-adoption after a closed copy the journal replays it as already applied and the base merge into hive/adopt-N silently does not happen; the fresh copy may open with the conflict the first adoption resolved. Pre-existing; the PR's scope covers the push/create claims that caused the revert loop.
Additional finding (folded in — same finding area and category). Raised in the Hive review of PR #15206 (#15206) and folded into this issue because it is a correctness finding at the same symbol or lines of src/pkg/github/automerge/automerge_contributor_adopt.go as this issue. Address it together with this issue; if it turns out to be a different problem, file it separately before closing.
Review backlog (correctness): Journal replay chain resolves only one level
Journal replay chain resolves only one level (src/pkg/github/automerge/automerge_contributor_adopt.go:866)
)
Finding: Journal replay chain resolves only one level
After openCopy(replayed) at :866, a second journal replay (store cleared twice at an unchanged head) yields created==nil, err==nil and falls to the 'adoption copy not opened' error at :872 every pass instead of claiming afresh. Identical in v5's cf1fe3a copy, so this is a follow-up on v5 (bounded loop), not a blocker here.
Unblocked: #15209 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.
🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.
Additional finding (folded in — same finding area and category). Raised in the Hive review of PR #15294 (#15294) and folded into this issue because it is a correctness finding at the same symbol or lines of src/pkg/github/automerge/automerge_contributor_adopt.go as this issue. Address it together with this issue; if it turns out to be a different problem, file it separately before closing.
Review backlog (correctness): Merge-time close in settleSuperseder remains ungated
Merge-time close in settleSuperseder remains ungated (src/pkg/github/automerge/automerge_contributor_adopt.go:1324)
Perspective: correctness
Severity: info (P3)
Evidence: src/pkg/github/automerge/automerge_contributor_adopt.go:1324 (
)
Finding: Merge-time close in settleSuperseder remains ungated
A gate-refused close-first falls to the keep-open path, whose merge-time close (PullRequests.Edit closed) is still a baselined raw write, so the original is closed ungated anyway. Acknowledged in the PR body as the automerge_contributor_adopt.go follow-up.
Activity
hivecommons-hive commentedon Oct 29, 2026
Unblocked: #15209 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Oct 29, 2026
Additional finding (folded in — same finding area and category). Raised in the Hive review of PR #15206 (#15206) and folded into this issue because it is a correctness finding at the same symbol or lines of
src/pkg/github/automerge/automerge_contributor_adopt.goas this issue. Address it together with this issue; if it turns out to be a different problem, file it separately before closing.Review backlog (correctness): Journal replay chain resolves only one level
src/pkg/github/automerge/automerge_contributor_adopt.go:866)Perspective: correctness
Severity: low (P3)
Evidence:
src/pkg/github/automerge/automerge_contributor_adopt.go:866(hive/src/pkg/github/automerge/automerge_contributor_adopt.go
Line 866 in c974dc3
Finding: Journal replay chain resolves only one level
After openCopy(replayed) at :866, a second journal replay (store cleared twice at an unchanged head) yields created==nil, err==nil and falls to the 'adoption copy not opened' error at :872 every pass instead of claiming afresh. Identical in v5's cf1fe3a copy, so this is a follow-up on v5 (bounded loop), not a blocker here.
Fingerprint:
c6a3fd57e7e359b0c979652140ea32350912229ad9825799cf40bb208ee1b8f3filed by Hive review backlog
hivecommons-hive commentedon Oct 29, 2026
Unblocked: #15209 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.
hivecommons-hive commentedon Oct 29, 2026
🔒 Claimed by agent
scanner(agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply/unclaimto release, or/claimto take it over if you outrank the holder.hivecommons-hive commentedon Oct 29, 2026
Additional finding (folded in — same finding area and category). Raised in the Hive review of PR #15294 (#15294) and folded into this issue because it is a correctness finding at the same symbol or lines of
src/pkg/github/automerge/automerge_contributor_adopt.goas this issue. Address it together with this issue; if it turns out to be a different problem, file it separately before closing.Review backlog (correctness): Merge-time close in settleSuperseder remains ungated
src/pkg/github/automerge/automerge_contributor_adopt.go:1324)Perspective: correctness
Severity: info (P3)
Evidence:
src/pkg/github/automerge/automerge_contributor_adopt.go:1324(hive/src/pkg/github/automerge/automerge_contributor_adopt.go
Line 1324 in 05bc859
Finding: Merge-time close in settleSuperseder remains ungated
A gate-refused close-first falls to the keep-open path, whose merge-time close (PullRequests.Edit closed) is still a baselined raw write, so the original is closed ungated anyway. Acknowledged in the PR body as the automerge_contributor_adopt.go follow-up.
Fingerprint:
392ccd2e0490394ab3f5b755bcdca453eefacad4676af67d41bf61bbc7ffaab7filed by Hive review backlog