Skip to content

Review backlog (correctness): Two capability-gap guards now coexist after rebase (#15127 policy regex + this PR's ledger short-circuit) #15217

Closed

Description

@hivecommons-hive

Blocked on PR #15134. This finding came from reviewing PR #15134 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #15134.

PR: #15134 (#15134)
Perspective: correctness
Severity: info (P3)
Evidence: src/pkg/dashboard/api_repo_item_decide_delegated.go:494 (

if in.Kind == delegatedecision.KindIssue {
)
Finding: Two capability-gap guards now coexist after rebase (#15127 policy regex + this PR's ledger short-circuit)

v5 commit 77d935f (#15127) added CapabilityGap/capabilityGapRE in delegatedecision/policy.go:350 returning recommendOnly with KeepsPark. This PR's delegatedBlocker short-circuit runs before decideDelegated so they do not conflict, but the same condition is now inferred by two independent regex sets with different texts; consider routing the policy fallback through pkg/blocker.Infer later.

Fingerprint: 6cacfb5d42edbee672ed88a8c2ddd75205f45bcbc9b54d975ff69c67322e3e47

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 29, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 29, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 29, 2026
  4. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15134 is no longer open. This issue is actionable again.

  5. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by @thatguywob (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  6. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 29, 2026
  7. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @thatguywob released (lease revoked).

  8. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15134 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions