Skip to content

🐛 Sentinel re-applies the alert to a head the owner just approved from the dashboard (dibs#510) #15214

Closed

Description

@clubanderson

What happened (live, hivecommons/dibs#510, 2026-10-29 UTC)

  • 23:30:22Z sentinel alerted head 674bcbb2 (sensitive_path .github/workflows/ci.yml), label sentinel-alert applied.
  • 23:55:54Z author pushed head 30e94a97. The label from the earlier head stayed on, so the sweep never alerted 30e94a97 itself (hasAlertLabel && decision.Block → skip).
  • 00:32:00–04Z owner clicked Approve in the dashboard: /lgtm + /approve posted with <!-- hive:pr-approval head=30e94a97… by=clubanderson -->, sentinel-alert removed by hivecommons-hive[bot] (00:32:07Z unlabeled event). Toast: released: approval-recorded, sentinel-label.
  • 00:33:56Z the sentinel sweep re-posted the full "⚠️ Sentinel alert — maintainer review required" for the same head 30e94a97 and re-applied sentinel-alert — the comment itself promising "Hive will not re-apply it unless new commits are pushed".
  • The contributor lane then skipped every cycle with contributor-lane:sentinel-blocked; stage reconciled back to 085-needs-decision. The owner's approval was silently undone within two minutes.

Root cause

trySentinelPR → no marker comment for 30e94a97 → sentinelClearedAfterLatestPush, which (correctly, #13602) refuses an unlabeled event whose actor is a hive account or bot. The dashboard release removes the label as the hive, so the sweep saw "new head, findings, label absent, nobody cleared it" and alerted. The release was persisted only as the label removal plus the human-change-request record — nothing the sentinel reads.

Also: on this Prow repo the bot is not in OWNERS, so the relayed /lgtm drew "changing LGTM is restricted to collaborators" and /approve drew "[APPROVALNOTIFIER] This PR is NOT APPROVED"; the commands are noise there.

Fix

  1. The sweep treats the hive's own hive:pr-approval head=<sha> comment as the release for exactly that head (durable on GitHub, restart-safe) and rewrites its marker comment as the released alert, as the 🐛 [v6] sentinel: a maintainer's clearance on a newer head is ignored, so the alert comes straight back #13602 path does. A new push re-arms.
  2. The lane side is already covered by 🐛 Activity Monitor: an owner's Approve admits the untrusted-author PR head — no adoption, merge as-is; DCO warned before acting #15156 (operator admission for the head); once the label stays off, sentinel-blocked clears. untrusted-author-role is the trusted-author lane's normal skip for this author, not a bug.
  3. When Prow has already rejected the hive's earlier commands on the PR, a later Approve records the decision without re-posting /lgtm + /approve and reports commands_skipped: prow-rejects-bot-commands in the response, toast and log.

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 29, 2026
  2. added 2 commits that reference this issue on Oct 29, 2026
    c453251
    ed22f02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions