Skip to content

Review backlog (correctness): Pending ledger record written after async job starts can be settled too early #15064

Closed

Description

@hivecommons-hive

Filed from an out-of-scope finding in the Hive review of PR #15056.

PR: #15056 (#15056)
Perspective: correctness
Severity: low (P3)
Evidence: src/pkg/dashboard/operator_actions.go:420 (

outcome, detail, head, record := operatorActionOutcome(cw.status, cw.body.Bytes())
)
Finding: Pending ledger record written after async job starts can be settled too early

recordOperatorAction runs h(cw, r) and only then Records the pending row, while the decide-delegated handler starts the job goroutine before answering 202 (api_repo_item_decide_delegated.go:65, 268). A job that finishes fast — e.g. every nested PR answered 'already running' at line 331 — calls Settle before the record exists (Settle returns false), and the record then stays pending forever. Pre-existing from #14992; the fan-out path makes the fast-finish case easier to hit.

Fingerprint: b2dca3cf82b4dd5f499eb80553c991fcb135df39b090b41e4540c37b622dfe6c

filed by Hive review backlog

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 28, 2026
  2. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by @thatguywob (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  3. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @thatguywob released (lease revoked).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions