Skip to content

Adoption orphaned when the hive's superseding copy is closed unmerged: original sits at 085 forever, Let hive decide says no change #15052

Closed

Description

@clubanderson

Observed (hive's hive, PR 14947 by @thatguywob, base v6)

  • 15:40Z: the hive decided supersede (rule contributor-offline) → <!-- hive:adopted … mode=supersede superseded_by=14977 head=bc3a6ea… -->, PR 14947 moved to stage/074 with its hive-authored copy 14977.
  • 15:46Z: the duplicate-fix sweep closed 14977 (<!-- hive:duplicate-fix --> Superseded by #14947). The sweep exemption for adoption pairs landed later in 🐛 Close superseded hive PRs automatically and re-stage adopted originals out of the merge gate #15011 — that part is fixed and not in scope here.
  • Now: 14947 is OPEN at stage/085-needs-decision (reviewer verdict requires_human); its superseded_by 14977 is CLOSED and not merged.

The adoption is orphaned: settleSuperseder saw the closed copy and forgot the adoption (ClearAdoption), but the PR's lane derives 085 from the reviewer verdict, so the 072 adoption machinery never runs again (its nudge head is stale too). Nothing progresses the PR, the tracker says "Needs human decision", and "Let hive decide" answers "No change — hive already recorded this decision (rule contributor-offline) at 15:40:11Z" because the delegated-decision dedup only looks at the prior decision comment, never at whether that decision still stands.

Expected

  1. Orphan detection on every stage-label pass: a PR with a supersede-mode adoption whose superseding PR is closed and not merged is orphaned. Recovery: re-adopt from the same head (fresh hive copy, fresh hive:adopted marker), logged as stage labels: adoption orphaned, re-adopting with old/new numbers. If re-adoption fails or the head moved, revert the PR to its pre-adoption flow (<!-- hive:adoption-reverted --> with plain words) so it is not stuck. Loop guard: a re-adopted copy closed again within the hour parks the PR at 085 with reason adoption-child-closed-twice, shown plainly in the tracker.
  2. A merged superseding PR still closes the original through the existing "Adopted → merged as #N" path (also when the stage record lost the adoption but the marker is on the PR).
  3. "Let hive decide" on an orphaned adoption must not answer "no change": it detects the dead superseded_by and re-queues the adoption, answering applied with "Re-adopting: hive's earlier copy #N was closed by mistake; opening a fresh copy".
  4. Tracker: an adopted PR whose copy is closed shows "Adopted → #N (closed) · recovering" instead of "Needs human decision"; after recovery, "Adopted → #M".

Acceptance

After roll, hive's hive re-adopts 14947 (new hive copy, new marker) within one stage-label pass.

Activity

  1. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    Contributor

    🔒 Claimed by @mendezr (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 28, 2026
  3. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    Contributor

    🔓 Claim by @mendezr released (lease revoked).

  4. added 2 commits that reference this issue on Oct 28, 2026
    d772475
    306e3f2
  5. added a commit that references this issue on Oct 28, 2026
    d46c60c
  6. added a commit that references this issue on Oct 28, 2026
    070ab85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions