Skip to content

Review backlog (intent-alignment): Queued path hands every prefilter rejection to the lane, not only label blocks #15047

Closed

Description

@hivecommons-hive

Blocked on PR #14945. This finding came from reviewing PR #14945 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #14945.

PR: #14945 (#14945)
Perspective: intent-alignment
Severity: info (P3)
Evidence: src/pkg/github/automerge/automerge_sweep.go:944 (

c.rejectPrefilteredBeforeLane(ctx, repo, owner, repoName, issue.GetNumber(), nil, hgithub.PRAuditPathQueue, reason)
)
Finding: Queued path hands every prefilter rejection to the lane, not only label blocks

src/pkg/github/automerge/automerge_sweep.go:943-944 calls rejectPrefilteredBeforeLane for any prefilterQueuedIssue reason, including label-removed, sentinel and exempt-label (automerge_sweep.go:2213-2227), each costing one PullRequests.Get on serialized repos (automerge_sweep.go:1971-1977). This matches the existing rejectBeforeLane contract for other rejections and stays within the issue's cost bound (direct repos make no call), so it is advisory only.

Fingerprint: 3fb8bb8b662a345e61b906774377078c59c904d59dfe296f3e240adac7422f83

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 28, 2026
  2. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    Same file as #15045: both cite src/pkg/github/automerge/automerge_sweep.go, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.

    filed by Hive review backlog

  3. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 28, 2026
  4. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 28, 2026
  5. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #14945 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.

  6. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #14945 is no longer open. This issue is actionable again.

  7. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    No change needed. The finding is advisory and self-described as matching the existing rejectBeforeLane contract and staying within the cost bound (direct repos make no call). The same v6 block (src/pkg/github/automerge/automerge_sweep.go:975) is intentional: the lane's own label policy decides whether a rejected front leaves. See docs in src/docs/labels-and-control-signals.md. Closing as not planned.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

  8. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Additional finding (folded in — same finding area and category). Raised in the Hive review of PR #15408 (#15408) and folded into this issue because it is a intent-alignment finding at the same symbol or lines of src/pkg/github/automerge/automerge_sweep.go as this issue. Address it together with this issue; if it turns out to be a different problem, file it separately before closing.

    Review backlog (intent-alignment): Queued-merge path still re-PUTs /merge on 405 required-checks-expected

    • Queued-merge path still re-PUTs /merge on 405 required-checks-expected (src/pkg/github/automerge/automerge_sweep.go:2698)

    Perspective: intent-alignment
    Severity: low (P3)
    Evidence: src/pkg/github/automerge/automerge_sweep.go:2698 (

    return AutoMergeSweepEvent{}, refused, nil
    )
    Finding: Queued-merge path still re-PUTs /merge on 405 required-checks-expected

    trySweepQueued (automerge_sweep.go:2681-2698) calls knownMergeRefusal but has no requiredChecksExpected branch; a 405 'N of M required status checks are expected' falls to refusedMerge -> "merge-failed", so a human-queued PR whose required checks have not reported is re-PUT every pass and lights 'Merge failed' exactly as #15404 describes. The PR body scopes the fix to the three other sites, so this is a pre-existing adjacent gap, not a regression.

    Fingerprint: bbde44216e5272308dfb0b80fd2f8f3d7a4b07a9165567557962693244bfa309

    filed by Hive review backlog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions