You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Review backlog (style): Held queued PRs never match the debug-level 'held' reason check #15045
Blocked on PR #14945. This finding came from reviewing PR #14945 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #14945.
)
Finding: Held queued PRs never match the debug-level 'held' reason check
Pre-existing: the skip log checks reason == "held", but prefilterQueuedIssue (:2213-2227) never returns that string; labelBlockReason returns "label:hold" (:2181). Held queued PRs therefore log at info instead of the intended debug level. Not introduced by this PR.
Unblocked: #14945 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.
Already fixed on v6: commit eb32ddd ("log held queued PRs at debug level") makes the skip log check reason == "held" || reason == "label:hold" || reason == "exempt-label" (src/pkg/github/automerge/automerge_sweep.go:978 on v6). The cited code (rejectPrefilteredBeforeLane, mergelane) exists only on v6; v5 has no lane handoff. Closing as not planned.
Additional finding (folded in — same finding area and category). Raised in the Hive review of PR #15430 (#15430) and folded into this issue because it is a style finding at the same symbol or lines of src/pkg/github/automerge/automerge_sweep.go as this issue. Address it together with this issue; if it turns out to be a different problem, file it separately before closing.
Review backlog (style): Self-authored lane uses literal "check-pending" instead of autoMergeReasonChecksExpected
Self-authored lane uses literal "check-pending" instead of autoMergeReasonChecksExpected (src/pkg/github/automerge/automerge_sweep.go:1953)
Perspective: style
Severity: info (P3)
Evidence: src/pkg/github/automerge/automerge_sweep.go:1953 (
)
Finding: Self-authored lane uses literal "check-pending" instead of autoMergeReasonChecksExpected
Pre-existing: the self-authored lane returns the string literal "check-pending" while the trusted-author lane (:2346) and the queued lane added by this PR (:2698) use the autoMergeReasonChecksExpected constant. Harmless today (same value) but a drift risk; replace the literal with the constant in a follow-up.
Activity
hivecommons-hive commentedon Oct 28, 2026
Unblocked: #14945 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.
hivecommons-hive commentedon Oct 28, 2026
Unblocked: #14945 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Oct 28, 2026
Already fixed on v6: commit eb32ddd ("log held queued PRs at debug level") makes the skip log check
reason == "held" || reason == "label:hold" || reason == "exempt-label"(src/pkg/github/automerge/automerge_sweep.go:978 on v6). The cited code (rejectPrefilteredBeforeLane, mergelane) exists only on v6; v5 has no lane handoff. Closing as not planned.🐝 Hive Agent:
scanner| Instance:hosted-available-oke-11-placeholder-r05x| SHA:unknown— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88
hivecommons-hive commentedon Oct 29, 2026
Additional finding (folded in — same finding area and category). Raised in the Hive review of PR #15430 (#15430) and folded into this issue because it is a style finding at the same symbol or lines of
src/pkg/github/automerge/automerge_sweep.goas this issue. Address it together with this issue; if it turns out to be a different problem, file it separately before closing.Review backlog (style): Self-authored lane uses literal "check-pending" instead of autoMergeReasonChecksExpected
src/pkg/github/automerge/automerge_sweep.go:1953)Perspective: style
Severity: info (P3)
Evidence:
src/pkg/github/automerge/automerge_sweep.go:1953(hive/src/pkg/github/automerge/automerge_sweep.go
Line 1953 in b89a144
Finding: Self-authored lane uses literal "check-pending" instead of autoMergeReasonChecksExpected
Pre-existing: the self-authored lane returns the string literal "check-pending" while the trusted-author lane (:2346) and the queued lane added by this PR (:2698) use the autoMergeReasonChecksExpected constant. Harmless today (same value) but a drift risk; replace the literal with the constant in a follow-up.
Fingerprint:
dced8064aac0fb4720266a04d4128061013a490ddb1ad6a02108f1ad19a690a4filed by Hive review backlog