Skip to content

Review backlog (style): Held queued PRs never match the debug-level 'held' reason check #15045

Closed

Description

@hivecommons-hive

Blocked on PR #14945. This finding came from reviewing PR #14945 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #14945.

PR: #14945 (#14945)
Perspective: style
Severity: low (P3)
Evidence: src/pkg/github/automerge/automerge_sweep.go:945 (

if reason == "held" || reason == "exempt-label" {
)
Finding: Held queued PRs never match the debug-level 'held' reason check

Pre-existing: the skip log checks reason == "held", but prefilterQueuedIssue (:2213-2227) never returns that string; labelBlockReason returns "label:hold" (:2181). Held queued PRs therefore log at info instead of the intended debug level. Not introduced by this PR.

Fingerprint: 16e471e1497f15680c3a15529292929d799f115c5280e359588faeab4ab4c1f9

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 28, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 28, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 28, 2026
  4. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #14945 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.

  5. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #14945 is no longer open. This issue is actionable again.

  6. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    Already fixed on v6: commit eb32ddd ("log held queued PRs at debug level") makes the skip log check reason == "held" || reason == "label:hold" || reason == "exempt-label" (src/pkg/github/automerge/automerge_sweep.go:978 on v6). The cited code (rejectPrefilteredBeforeLane, mergelane) exists only on v6; v5 has no lane handoff. Closing as not planned.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

  7. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Additional finding (folded in — same finding area and category). Raised in the Hive review of PR #15430 (#15430) and folded into this issue because it is a style finding at the same symbol or lines of src/pkg/github/automerge/automerge_sweep.go as this issue. Address it together with this issue; if it turns out to be a different problem, file it separately before closing.

    Review backlog (style): Self-authored lane uses literal "check-pending" instead of autoMergeReasonChecksExpected

    • Self-authored lane uses literal "check-pending" instead of autoMergeReasonChecksExpected (src/pkg/github/automerge/automerge_sweep.go:1953)

    Perspective: style
    Severity: info (P3)
    Evidence: src/pkg/github/automerge/automerge_sweep.go:1953 (

    return AutoMergeSweepEvent{}, "check-pending", nil
    )
    Finding: Self-authored lane uses literal "check-pending" instead of autoMergeReasonChecksExpected

    Pre-existing: the self-authored lane returns the string literal "check-pending" while the trusted-author lane (:2346) and the queued lane added by this PR (:2698) use the autoMergeReasonChecksExpected constant. Harmless today (same value) but a drift risk; replace the literal with the constant in a follow-up.

    Fingerprint: dced8064aac0fb4720266a04d4128061013a490ddb1ad6a02108f1ad19a690a4

    filed by Hive review backlog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions