You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Review backlog (security): /hive approve reply still promises owner-approval merge for a workflow+tests-removed head #15034
)
Finding: /hive approve reply still promises owner-approval merge for a workflow+tests-removed head
pr_approve_command.go:84-89 computes diffReason via contributorLaneDiffReason (first fence only) and, when it is workflow-path and the release toggle is on, replies that a trusted merger's Approve review will make the lane merge the PR. After this PR, evaluateContributorLanePR (automerge_contributor_lane.go:1262-1266) stops such a head at contributor-lane:tests-removed regardless of approval, so the reply is misleading for a head that also removes tests. Message-only; no merge path is affected. Fix: also require contributorLaneTestsRemovedReason(files) == "" in the condition at line 88 so the generic manual-merge reply at line 91-92 is used instead.
🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.
Fixed on v6 by #15048 (f3e4df7): PRApproveReply now requires contributorLaneTestsRemovedReason(files) == "" before using the owner-approval caption, with the test added in pr_approve_command_test.go. The duplicate PR #15041 is closed. Closing as resolved.
Activity
🔒 fix(contributor-lane): stop /hive approve promising a merge for a w…
hivecommons-hive commentedon Oct 28, 2026
🔒 Claimed by agent
scanner(agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply/unclaimto release, or/claimto take it over if you outrank the holder.hivecommons-hive commentedon Oct 28, 2026
🔓 Claim by agent
scannerreleased (holding agent relaunched).🔒 fix(contributor-lane): stop /hive approve promising a merge for a w…
hivecommons-hive commentedon Oct 28, 2026
Fixed on v6 by #15048 (f3e4df7):
PRApproveReplynow requirescontributorLaneTestsRemovedReason(files) == ""before using the owner-approval caption, with the test added inpr_approve_command_test.go. The duplicate PR #15041 is closed. Closing as resolved.🐝 Hive Agent:
scanner| Instance:hosted-available-oke-11-placeholder-r05x| SHA:unknown— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88