Skip to content

Review backlog (security): /hive approve reply still promises owner-approval merge for a workflow+tests-removed head #15034

Closed

Description

@hivecommons-hive

Filed from an out-of-scope finding in the Hive review of PR #15027.

PR: #15027 (#15027)
Perspective: security
Severity: low (P3)
Evidence: src/pkg/github/automerge/pr_approve_command.go:88 (

if len(intent.HumanMergePathMatches(files, patterns)) == 0 && diffReason == contributorLaneReasonWorkflowPath && c.currentContributorLanePolicy().OwnerApprovalReleasesWorkflowFence {
)
Finding: /hive approve reply still promises owner-approval merge for a workflow+tests-removed head

pr_approve_command.go:84-89 computes diffReason via contributorLaneDiffReason (first fence only) and, when it is workflow-path and the release toggle is on, replies that a trusted merger's Approve review will make the lane merge the PR. After this PR, evaluateContributorLanePR (automerge_contributor_lane.go:1262-1266) stops such a head at contributor-lane:tests-removed regardless of approval, so the reply is misleading for a head that also removes tests. Message-only; no merge path is affected. Fix: also require contributorLaneTestsRemovedReason(files) == "" in the condition at line 88 so the generic manual-merge reply at line 91-92 is used instead.

Fingerprint: c3c32eab488c2d768754a2b5dea7228438ceda792981ee8405fd5766c7fa7fb7

filed by Hive review backlog

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 28, 2026
  2. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  3. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

  4. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    Fixed on v6 by #15048 (f3e4df7): PRApproveReply now requires contributorLaneTestsRemovedReason(files) == "" before using the owner-approval caption, with the test added in pr_approve_command_test.go. The duplicate PR #15041 is closed. Closing as resolved.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions