Skip to content

Adoption never takes a repository maintainer's clanker PR and the UI never says why (#14524 stuck 26h at 072) #15015

Closed

Description

@clubanderson

Evidence (hive's own hosted spoke, 2026-10-28)

PR #14524 (author @hanthor, XXL, CONFLICTING, two failing ratchets, reviewer changes_requested) has sat at stage/072-returned-to-contributor for 26h, nudged twice. hanthor's hive is not connected (fleet shows no presence). Every cycle hive logs:

stage labels: adoption due but the author maintains the repository; not adopting repo=hive pr=14524 author=hanthor deferred=false

The activity monitor row reads a bare "Returned to contributor — @hanthor must act (2 nudges sent)". Owner: "Is hanthor offline? If so this should get adopted, no?" — and nothing on screen explains why it isn't.

Cause

The hands-off rule from #14301 / #14305 (backstop for projectbluefin/utah-packages#619) is hard-coded: a due adoption of a PR whose author holds admin/maintain on the repository is skipped, and existing adoptions of such heads are released. The hold is logged but never recorded on the stage record or surfaced in the tracker payload, so the UI cannot say so and offers no way out.

Owner decision (12:28 ET, 2026-10-28)

We should adopt PRs regardless of who they are from. If they are clankers (author/clanker — PR authored by a contributor's hive agent) then we reserve the right to adopt if they disconnect.

Fix

  • governor.labels.stage.adoption.maintainer_policy: adopt | ask | never, default adopt — clanker PRs are adoptable on disconnect regardless of the owner's repo role; the trigger is the same as for any contributor (author/clanker PR + contributor's hive disconnected past the nudge window). Human-authored PRs keep the existing rule (never adopted). ask / never remain opt-outs; ask parks the PR for an owner decision and the row offers Adopt.
  • Tracker payload adoption{due, blocked_by, since, nudges, author_online, …} and a plain-words row pill/tooltip: "waiting on @hanthor (maintainer, offline 26h) — adopt?".
  • Decision API decision: "adopt" (attributed to the owner, reusing the adoption/supersede adopt/supersede path that produced 🐛 fix: reject auto-merge queues from untrusted merger identities #14977 / 📖 docs: explain webhook claim ledger and pending stage recovery #14980); Settings → Features three-way selector.

Acceptance: #14524 is adopted by hive's hive on the first cycle after this rolls (not adopted manually).

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 28, 2026
  2. github-actions commented on Oct 28, 2026

    @github-actions
    Contributor

    @clubanderson this issue was closed by @hivecommons-hive[bot] as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions