You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Review backlog (security): Comment-only cross-references from any same-repo commenter still promote an issue to Reviewing #14985
Blocked on PR #14974. This finding came from reviewing PR #14974 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #14974.
)
Finding: Comment-only cross-references from any same-repo commenter still promote an issue to Reviewing
src/pkg/dashboard/contribute_prlink.go:272-280 accepts a timeline cross-referencing PR whose title/body never names the issue (the #14859 comment path). Since any user who can comment on a same-repo PR creates such a cross-reference, they can flip an issue's dashboard state to Reviewing. This is read-only dashboard state, bounded by the same-repo check at contribute_prlink.go:233-235, and is the merge-base behavior rather than something this delta introduces; noted for completeness, not a blocker.
Same file as #14966: both cite src/pkg/dashboard/contribute_prlink.go, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.
🔒 Claimed by @mendezr (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.
Unblocked: #14974 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.
Additional finding (folded in — same finding area and category). Raised in the Hive review of PR #15005 (#15005) and folded into this issue because it is a security finding at the same symbol or lines of src/pkg/dashboard/contribute_prlink.go as this issue. Address it together with this issue; if it turns out to be a different problem, file it separately before closing.
Review backlog (security): searchHitClosesIssue still fails open when the Search API omits title and body
searchHitClosesIssue still fails open when the Search API omits title and body (src/pkg/dashboard/contribute_prlink.go:272)
)
Finding: searchHitClosesIssue still fails open when the Search API omits title and body
This PR makes the timeline path fail closed (prClosesIssue at contribute_prlink.go:282 now requires github.FindClosingKeywordReference to match), but the parallel search-hit gate at contribute_prlink.go:272-274 still returns true when title and body are both empty. GitHub issue search indexes comments too, so a same-repo PR returned by repo:X type:pr N on a comment-only mention would be promoted if the API ever omitted its text. Pre-existing at merge-base and not touched by this diff; low practical risk because Search.Issues normally populates title/body. Fix: drop the empty-text early return so the search gate matches the new timeline gate.
Activity
hivecommons-hive commentedon Oct 28, 2026
Same file as #14966: both cite
src/pkg/dashboard/contribute_prlink.go, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.filed by Hive review backlog
hivecommons-hive commentedon Oct 28, 2026
Unblocked: #14974 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Oct 28, 2026
🔒 Claimed by @mendezr (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply
/unclaimto release, or/claimto take it over if you outrank the holder.hivecommons-hive commentedon Oct 28, 2026
🔓 Claim by @mendezr released (lease revoked).
hivecommons-hive commentedon Oct 28, 2026
Unblocked: #14974 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.
hivecommons-hive commentedon Oct 28, 2026
Additional finding (folded in — same finding area and category). Raised in the Hive review of PR #15005 (#15005) and folded into this issue because it is a security finding at the same symbol or lines of
src/pkg/dashboard/contribute_prlink.goas this issue. Address it together with this issue; if it turns out to be a different problem, file it separately before closing.Review backlog (security): searchHitClosesIssue still fails open when the Search API omits title and body
src/pkg/dashboard/contribute_prlink.go:272)Perspective: security
Severity: low (P3)
Evidence:
src/pkg/dashboard/contribute_prlink.go:272(hive/src/pkg/dashboard/contribute_prlink.go
Line 272 in 71783cd
Finding: searchHitClosesIssue still fails open when the Search API omits title and body
This PR makes the timeline path fail closed (prClosesIssue at contribute_prlink.go:282 now requires github.FindClosingKeywordReference to match), but the parallel search-hit gate at contribute_prlink.go:272-274 still returns true when title and body are both empty. GitHub issue search indexes comments too, so a same-repo PR returned by
repo:X type:pr Non a comment-only mention would be promoted if the API ever omitted its text. Pre-existing at merge-base and not touched by this diff; low practical risk because Search.Issues normally populates title/body. Fix: drop the empty-text early return so the search gate matches the new timeline gate.Fingerprint:
9c9ca0c30c3b72d7131a92a52a7c0943f2d8bff883de445b575500372985ff2efiled by Hive review backlog
🐛 fix(dashboard): require closing intent for timeline PR links (#15005)