Skip to content

Review backlog (security): Comment-only cross-references from any same-repo commenter still promote an issue to Reviewing #14985

Closed

Description

@hivecommons-hive

Blocked on PR #14974. This finding came from reviewing PR #14974 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #14974.

PR: #14974 (#14974)
Perspective: security
Severity: info (P3)
Evidence: src/pkg/dashboard/contribute_prlink.go:276 (

if !prMentionsIssue(text, repo, number) {
)
Finding: Comment-only cross-references from any same-repo commenter still promote an issue to Reviewing

src/pkg/dashboard/contribute_prlink.go:272-280 accepts a timeline cross-referencing PR whose title/body never names the issue (the #14859 comment path). Since any user who can comment on a same-repo PR creates such a cross-reference, they can flip an issue's dashboard state to Reviewing. This is read-only dashboard state, bounded by the same-repo check at contribute_prlink.go:233-235, and is the merge-base behavior rather than something this delta introduces; noted for completeness, not a blocker.

Fingerprint: d0d2c6fd8ec61b788c91355339107ce4608f7033a0731f28696cd5c3302da9d9

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 28, 2026
  2. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    Same file as #14966: both cite src/pkg/dashboard/contribute_prlink.go, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.

    filed by Hive review backlog

  3. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 28, 2026
  4. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 28, 2026
  5. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #14974 is no longer open. This issue is actionable again.

  6. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by @mendezr (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  7. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 28, 2026
  8. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @mendezr released (lease revoked).

  9. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #14974 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.

  10. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    Additional finding (folded in — same finding area and category). Raised in the Hive review of PR #15005 (#15005) and folded into this issue because it is a security finding at the same symbol or lines of src/pkg/dashboard/contribute_prlink.go as this issue. Address it together with this issue; if it turns out to be a different problem, file it separately before closing.

    Review backlog (security): searchHitClosesIssue still fails open when the Search API omits title and body

    • searchHitClosesIssue still fails open when the Search API omits title and body (src/pkg/dashboard/contribute_prlink.go:272)

    Perspective: security
    Severity: low (P3)
    Evidence: src/pkg/dashboard/contribute_prlink.go:272 (

    if title == "" && body == "" {
    )
    Finding: searchHitClosesIssue still fails open when the Search API omits title and body

    This PR makes the timeline path fail closed (prClosesIssue at contribute_prlink.go:282 now requires github.FindClosingKeywordReference to match), but the parallel search-hit gate at contribute_prlink.go:272-274 still returns true when title and body are both empty. GitHub issue search indexes comments too, so a same-repo PR returned by repo:X type:pr N on a comment-only mention would be promoted if the API ever omitted its text. Pre-existing at merge-base and not touched by this diff; low practical risk because Search.Issues normally populates title/body. Fix: drop the empty-text early return so the search gate matches the new timeline gate.

    Fingerprint: 9c9ca0c30c3b72d7131a92a52a7c0943f2d8bff883de445b575500372985ff2e

    filed by Hive review backlog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthas-open-prhelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions