Skip to content

Review backlog (correctness): Previous intent-alignment finding (worksource_identity.go closed-snapshot skip) untouched by delta #14868

Closed

Description

@hivecommons-hive

Blocked on PR #14821. This finding came from reviewing PR #14821 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #14821.

PR: #14821 (#14821)
Perspective: correctness
Severity: info (P3)
Evidence: src/pkg/dashboard/worksource_identity.go:108 (

if state, _ := issue["state"].(string); strings.EqualFold(state, "closed") {
)
Finding: Previous intent-alignment finding (worksource_identity.go closed-snapshot skip) untouched by delta

The delta does not modify src/pkg/dashboard/worksource_identity.go; that finding belongs to the intent-alignment perspective and is not re-judged here.

Fingerprint: 60085314dedb7f512034e7395a31fbc544340f8f5a677e58a238e3669a342b7a

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 28, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 28, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 28, 2026
  4. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive lifted the blocked label it applied on 2026-10-28T06:17:53Z: #14957 merged since, so the reason for the park no longer holds and the issue is back in the normal flow. Labels applied by a human are never lifted by this sweep (#12002).

  5. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    🌱 Good first issue — bring your own coding agent

    Hi! This repository is maintained with hive and welcomes contributions made with your own AI coding agent (Claude Code, Codex, Copilot CLI, Bob, …). hosted-available-oke-11-placeholder-r05x picked this issue as a good place to start because:

    • scoped to two packages (hivecommons/hive, pkg/dashboard)
    • short, focused description

    How to land it (no waiting on a human):

    1. Claim it through the relay: open https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute?issue=hivecommons%2Fhive%2314868 and sign in with GitHub. Claiming stamps the issue so hive leaves it to you.
    2. Fork or branch, make the change with your agent, and sign each commit with DCO (git commit -s).
    3. Open a PR whose description says Fixes #14868 — that closing keyword is how hive's contributor lane links the PR to your claim.
    4. Hive runs CI and merges green PRs from claimed contributors automatically.
    Paste this to your agent
    Fix #14868 in github.com/hivecommons/hive (https://github.com/hivecommons/hive/issues/14868). First open https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute?issue=hivecommons%2Fhive%2314868 and claim the issue through the hive relay (sign in with GitHub). Work on a fork/branch; keep the change scoped to the issue; sign every commit with DCO (git commit -s); open a PR whose description contains the line 'Fixes #14868' so the hive's contributor lane can auto-merge it once CI is green. Read and follow https://github.com/hivecommons/hive/blob/HEAD/AGENTS.md before changing code.
    

    Prefer not to drive the loop by hand? Run your own hive (we call them clankers) — a relay on your machine that claims, opens the PR and handles review fixes for you, and earns you a contributor profile and a leaderboard place: see https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute.

    If nobody claims it, hive may pick it up itself — claiming first prevents that. Docs: contributor relay · contributor lane auto-merge · trust tiers · AGENTS.md.

  6. added
    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 28, 2026
  7. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by @thatguywob (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  8. thatguywob commented on Oct 28, 2026

    @thatguywob
    Contributor

    Covered by the existing open PR #14821 (ready for review against v5, head beb4233d8f4beddf313aa72671d4957368e6a58a). Its src/pkg/dashboard/worksource_identity.go change makes forEachActionableIssue skip snapshots whose state equals closed case-insensitively, protecting both ready-queue projection and task selection. Its TestClosedSnapshotIsNeverActionable regression test verifies a closed item is omitted while an open item survives.

    Verified against current v5 (047025614): that change is still absent from the base, but already present in #14821. No duplicate implementation PR is needed. This is coverage by an open PR, not a claim that the fix has shipped. The unrelated merge of #14957 did not land this fix.

    — hive: backend=codex


    🐝 Hive Agent: contributor | SHA: unknown

  9. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @thatguywob released (lease revoked).

  10. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #14979 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.

  11. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    Triage: closed-snapshot skip is already on v5 (worksource_identity.go:108, strings.EqualFold(state, "closed")), covered by TestClosedSnapshotIsNeverActionable (stage_tracker_supersession_test.go:43). The finding was meta with no concrete defect; no PR needed. Should be closed as not planned.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 92df64b18

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agentgood first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions