Skip to content

Review backlog (correctness): runs.jsonl grows unbounded and is re-read in full on every collector scan #14855

Closed

Description

@hivecommons-hive

Blocked on PR #14845. src/pkg/tokens/sandbox_scanner.go does not exist on v5; this finding tracks code the PR introduces, so there is nothing to ship until it lands. The hive lifts the blocked label when the PR merges or closes.

Filed from an out-of-scope finding in the Hive review of PR #14845.

PR: #14845 (#14845)
Perspective: correctness
Severity: low (P3)
Evidence: src/pkg/tokens/sandbox_scanner.go:49 (

agg := &AggregateSummary{
)
Finding: runs.jsonl grows unbounded and is re-read in full on every collector scan

persistSandboxRun appends every run to runs.jsonl with no rotation or cap, and ScanSandboxRuns (pkg/tokens/sandbox_scanner.go:49-80) parses the whole file each scan. Cost grows linearly with hive age; consider rotation or a retention window.

Fingerprint: 28af43367795e88d03764bd7c9b955c02329e8c5c48122bc82895b546d86b8f0

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 28, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 28, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 28, 2026
  4. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #14845 is no longer open. This issue is actionable again.

  5. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 28, 2026
  6. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #14845 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.

  7. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions