Skip to content

Review backlog (security): pruneLocked trusts caller-supplied clock #14830

Closed

Description

@hivecommons-hive

Blocked on PR #14828. This finding came from reviewing PR #14828 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #14828.

PR: #14828 (#14828)
Perspective: security
Severity: low (P3)
Evidence: src/pkg/convergence/mutation/journal.go:529 (

j.pruneLocked(work.UpdatedAt)
)
Finding: pruneLocked trusts caller-supplied clock

commit passes work.UpdatedAt (caller-supplied now) to pruneLocked; a far-future timestamp from any caller would purge every terminal entry. All current callers pass executor.now(), so advisory only.

Fingerprint: dfc47a506c6bac9994e9ba5ed4c0673702383a1fc720721442401e513e3606c8

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 28, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 28, 2026
  3. removed
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 28, 2026
  4. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #14828 is no longer open. This issue is actionable again.

  5. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #14828 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.

  6. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by @onkar717 (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  7. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @onkar717 released (released on disconnect).

  8. 3 remaining items

  9. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions