Skip to content

🐛 contribute relay: completed PR is never linked to the dispatched issue (Fixes #N missing) #14763

Closed

Description

@clubanderson

Observed

In the hosted "hive's hive" (2026-10-27), the /contribute relay dispatched #14633 (Hub PKCE S256 verifier cookie) to a trusted contributor. The contributor shipped PR #14701 and reported task complete with verdict shipped; the hub verified the PR ([contribute-ws] reported PR verified), ran reconcilePRAttribution (hive trailer) and released the 4h claim lease.

But #14701's body contains no Fixes #14633 and no sidebar closing link. Consequences:

  • prclaims derives claims only from PR text / branch name, so the ledger never saw [scanner] hub-auth: add S256 PKCE verifier cookie to Hub GitHub login #14633 as covered → the issue stayed at stage/010-actionable for hours while its implementation sat at 085 "no linked issue".
  • The reviewer swarm parked the PR as "no linked issue" and could not see the issue's Target branch note (the PR landed on v5; the issue asked for v6).
  • The scanner and other contributors could re-claim the already-implemented issue.

contributorPRClosingInstruction only asks the contributor model for Closes #N; nothing enforces it. EnsureIssueStagePRLink deliberately never edits non-bot PR bodies, so no existing path backfills the link.

Expected

When a relay task of kind issue completes with a verified PR (open, same repo, authored by the verified contributor login), the hub must make the PR↔issue link durable:

  1. append Fixes #N (or Refs #N when the task was a partial/Refs declaration) to the PR body if it carries no closing reference to that issue, and
  2. call EnsureClosingIssueLink so the GitHub sidebar shows it even when the PR base is not the default branch.

Log the backfill as [contribute-ws] linked reported PR to dispatched issue.

Evidence

Activity

  1. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    Contributor

    🔒 Claimed by @thatguywob (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 28, 2026
  3. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    Contributor

    🔓 Claim by @thatguywob released (lease revoked).

  4. github-actions commented on Oct 28, 2026

    @github-actions
    Contributor

    @clubanderson this issue was closed by @hivecommons-hive[bot] as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

  5. added 2 commits that reference this issue on Oct 28, 2026
    4fc7d11
    70716fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions