Skip to content

[scanner] repeat-failure: omp route emits the shared command record + re-runnable harness #14747

Closed

Description

@hivecommons-hive

Part of #14559 (per-backend split of the backend-specific routes). Epic: #14550. Target: v6 (open the PR with --base v6).

Scope (C1, C3, C14): omp runs commands in a shell embedded in the omp process and deliberately strips BASH_ENV. Add a Hive-owned omp extension that listens to the tool_result event for the bash tool and appends one shared command record (route e.g. omp_extension; command and exit code / failed from the event fields — check which exist) to RepeatFailureRecordPath($HOME). Follow the advisor pattern in src/crux/agent/advisor_omp.go (ompAdvisorExtension, ompAdvisorLaunchFlag: file rendered into the Hive-owned ~/.hive-advisor/ dir and passed with --extension; reached via advisorLaunchFlag in src/crux/agent/advisor_hook.go and the case "omp" in backendLaunchCmdWithBobSession, src/crux/agent/manager_launch.go). The record extension must be passed independently of the advisor (its own --extension when only the check is on) and fail open (no record, never block the tool).

Only Hive-owned files and launch flags; never edit omp's own config.yml. With repeat_failure.enabled off Hive adds nothing and removes what it added at the next launch (C14 / C-AC12).

Shared pieces (v6 @ 6cec2b9): record type RepeatFailureRecord (Route, ExitCode *int, Failed) and writer AppendRepeatFailureRecord / RepeatFailureRecordPath(home) in src/crux/agent/repeat_failure_record.go (the extension must write the same one-line JSON format); switch via Manager.repeatFailureEnabled() in src/crux/agent/repeat_failure_bash_env.go. Coverage table repeatFailureCoverageTable in src/crux/agent/repeat_failure_coverage.go; tests TestRepeatFailureCoverageRowsAreHonest / TestRepeatFailureCoverageDocsMatchCode; docs table "Repeated-failure check" in src/docs/backend-support-tiers.md (~line 550).

Harness (C4): a committed, re-runnable harness with the real omp CLI (.github/workflows/omp-smoke.yml is a starting point; stub model provider or recorded fixture) that records omp --version and shows one failing command (false / ls /nonexistent) recorded. Update the omp row in repeatFailureCoverageTable (Covered, Route, Evidence incl. --version, EvidencePath, ShellActivity) and the matching docs row.

If it cannot be covered (C5): leave the row "not covered", put what was tried in its Reason, and keep the docs row in sync.

Acceptance: C-AC1 for omp when covered, else C-AC9; the C-AC11 coverage test stays green.

Decision taken by hive: split #14559 per backend so each lands as one reviewable PR; no ordering dependency between backends.

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Activity

  1. added
    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    agent/scannerCreated or modified by the scanner agent
    on Oct 28, 2026
  2. added
    stage/010-actionableTriaged; eligible for the hive to pick up
    stage/020-claimedClaimed by the scanner or a relay contributor
    and removed
    stage/010-actionableTriaged; eligible for the hive to pick up
    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.
    on Oct 28, 2026
  3. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  4. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

  5. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by @thatguywob (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  6. 4 remaining items

  7. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @thatguywob released (lease revoked).

  8. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  9. github-actions commented on Oct 28, 2026

    @github-actions
    Contributor

    Closed by #14801 (merged to v6).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/scannerCreated or modified by the scanner agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.hive/claimed-by-scanner

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions