Skip to content

Review backlog (correctness): Repair path cannot move two or more late-added pack-owned CLI agents #14721

Closed

Description

@hivecommons-hive

Blocked on PR #14710. This finding came from reviewing PR #14710 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #14710.

PR: #14710 (#14710)
Perspective: correctness
Severity: low (P3)
Evidence: src/pkg/dashboard/api_packs.go:214 (

if gw := gatewayPlacement(packBackend, backendReplaced, s.hiveGatewayBackend(hiveBackends, pa.Name)); gw != "" &&
)
Finding: Repair path cannot move two or more late-added pack-owned CLI agents

On a hive that already has two pack-owned copilot agents added after the operator's gateway move (e.g. reviewer plus a later-level agent), each one counts as a CLI agent in the snapshot for the other, so hiveGatewayBackend returns "" for both and neither is repaired. The create path handles this (new agents are absent from the snapshot) but the repair path does not. Adjacent to #14678 (single reviewer); noting for backlog.

Fingerprint: 8f4d63e3faf6f963ce9ba93dce7d1c50a1b559f2c2e00882709bd9ab69983471

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 27, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 27, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 27, 2026
  4. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    Re-targeted: blocker #14710 was superseded by #14777.

  5. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    Additional finding (folded in — same finding area and category). Raised in the Hive review of PR #14777 (#14777) and folded into this issue because it is a correctness finding at the same symbol or lines of src/pkg/dashboard/api_packs.go as this issue. Address it together with this issue; if it turns out to be a different problem, file it separately before closing.

    Review backlog (correctness): Pack-owned agents follow the gateway only from the pack CLI, not across a later gateway change

    • Pack-owned agents follow the gateway only from the pack CLI, not across a later gateway change (src/pkg/dashboard/api_packs.go:214)

    Perspective: correctness
    Severity: low (P3)
    Evidence: src/pkg/dashboard/api_packs.go:214 (

    // wrote moves — never an operator's pick, nor a legacy unowned one.
    )
    Finding: Pack-owned agents follow the gateway only from the pack CLI, not across a later gateway change

    api_packs.go:214 moves an existing pack-owned agent only when existing.Backend still equals the pack CLI backend. Agents an earlier apply moved onto gateway A stay there if the operator later moves every operator-picked agent to gateway B, even though they remain pack-owned. Consistent with the documented intent (api_packs.go:1178-1197) and sufficient for #14678, but 'follow the hive's gateway' is one-hop only.

    Fingerprint: d96b7bc4cde53ee88bf2d31a4d60b01b6faa8108f0f3d6a691fbacb70e63cf96

    filed by Hive review backlog

  6. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    Additional finding (folded in — same finding area and category). Raised in the Hive review of PR #14777 (#14777) and folded into this issue because it is a correctness finding at the same symbol or lines of src/pkg/dashboard/api_packs.go as this issue. Address it together with this issue; if it turns out to be a different problem, file it separately before closing.

    Review backlog (correctness): Hive-default gateway (empty backend) still not detected as 'the hive's gateway'

    • Hive-default gateway (empty backend) still not detected as 'the hive's gateway' (src/pkg/dashboard/api_packs.go:1217)

    Perspective: correctness
    Severity: info (P3)
    Evidence: src/pkg/dashboard/api_packs.go:1217 (

    shared = vote.backend
    )
    Finding: Hive-default gateway (empty backend) still not detected as 'the hive's gateway'

    Unchanged from the previous head: hiveGatewayBackend returns "" when operator picks are empty/hive-default, so a hive whose gateway is configured only via the default backend never triggers the move. Open question carried forward; the delta does not change it.

    Fingerprint: affde11b9e1725ce22603192e14567d88f3d9b27075e8165310cdf3ea8afe315

    filed by Hive review backlog

  7. removed
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 28, 2026
  8. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #14777 is no longer open. This issue is actionable again.

  9. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    Good first issue — superseded: hosted-available-oke-11-placeholder-r05x started working on this issue itself (claimed-by-hive, 2026-10-28T03:33:02Z), so the good first issue label has been removed. Thanks for looking! Other issues open to new contributors are listed on the relay page: https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute

  10. added
    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    stage/010-actionableTriaged; eligible for the hive to pick up
    on Oct 28, 2026
  11. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #14777 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.

  12. added
    stage/020-claimedClaimed by the scanner or a relay contributor
    and removed
    stage/010-actionableTriaged; eligible for the hive to pick up
    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.
    on Oct 28, 2026
  13. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.hive/claimed-by-scanner

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions