Repository navigation
Closed
Labels
help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.
Description
Symptom
A /hive decision approve followed by numbered instructions on a hive-authored PR parked at stage/085-needs-decision is acknowledged by the hive ("this PR moves to the fixing stage and the author agent pushes a new head following your instruction verbatim") but the PR never leaves 085, and the fix the author agent eventually receives carries only the word approve instead of the instructions.
Timeline (hive#14628, head 3b4a2b5)
- 18:25:24Z @clubanderson comments
/hive decision approve+ 3 numbered instructions (changeCloses #14605→Refs #14605, keep 🐛 review-fix: follow-up commits pushed by hive/relay agents lack Signed-off-by, bouncing the PR to no-dco / 072 #14605 open, merge on green). - 18:35:37Z hive replies
<!-- hive:unpark-reply:9879 id=6450262272 -->"Decision recorded … treating it as a changes requested review: this PR moves to the fixing stage …". - 18:58Z pod restarted.
- 19:08Z labels still
stage/085-needs-decision, body stillCloses #14605, no new head. Pod logs for"pr":14628:automerge skipwithcontributor-lane:decision-requested,human-changes-requested,trusted-author:app-authored;stage labels: reviewer verdict route; no fix kick. /data/review-human-change-requests.jsonholds the recorded request for 14628/3b4a2b5 with"body": "approve"— the instructions were dropped.- 19:11:23Z a fix was finally dispatched to the in-pod agent, with instruction text
approve.
Root causes
pkg/github/issue_unpark_command.goparseUnparkCommandkeeps only the first non-empty line of the comment, so the recorded change request and the fix prompt sayapproveand lose the numbered instructions.pkg/stageengine/derive_pr_classify.goClassifyStageanswers the reviewer'sDecisionRequested/RequiresHumanverdict (→ 085) before it looks at the lane'shuman-changes-requestedreason (→ 070). A recorded owner decision on the current head therefore never outranks the swarm's needs-decision verdict on the same head; the lane keeps reportingcontributor-lane:decision-requestedand the stage stays 085.- A bare
/hive decision approve(no instructions) is also recorded as a change request, so the PR is told to "fix" with the textapproveinstead of being released toward 090/merge.
Required behaviour
- An owner decision on head H supersedes the reviewer
requires_humanverdict on H; the lane stops reportingdecision-requested. - Decision with instructions → 070 immediately, fix kick with the decision text verbatim (hive-authored heads dispatch to the in-pod agent).
- Bare
/hive decision approve→ approval; existing 090/merge rules apply. - Idempotent across restarts: an already-acknowledged decision (the
hive:unpark-replymarker) is reconstructed from GitHub comments when the store has no record for the current head. - One log line per transition:
decision: unpark pr=… head=… mode=changes_requested|approve by=… → stage=….
Metadata
Metadata
Assignees
Labels
help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.
Activity
github-actions commentedon Oct 27, 2026
@clubanderson this issue was closed by @hivecommons-hive[bot] as completed.
If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.
If you are still seeing the problem, comment
/reopenand it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.hivecommons-hive commentedon Oct 27, 2026
Checked against
v5@ b352ac8. Both defects are already fixed by b352ac8 (#14684), so no new PR is needed:approve:src/pkg/github/issue_unpark_command.goparseUnparkCommandnow passes the whole comment throughdecisionText(line 963 / 971), so the recorded request and fix kick carry the numbered instructions. A bare/hive decision approveis recorded with kind approve and is no longer treated as a change request (src/pkg/review/human_change_request.go).src/pkg/stageengine/derive_pr_classify.goRequiresHumanStage(line 461) now steps aside whenTrustedHumanChangeRequestedholds for the head, so a decision on the current head derives 070 (human-changes-requested). The un-park path also submits aPRDecidedfact so 070 is written in the same pass as the reply. On restart,src/pkg/github/pr_unpark_decision.gorebuilds a missing or first-line-only record from the acknowledgedhive:unpark-replythread for the live head.The fix only takes effect after a deployment that includes b352ac8.
🐝 Hive Agent:
scanner| Instance:hosted-available-oke-11-placeholder-r05x| SHA:bcad0c9b5— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88
fix(stage): treat a recorded /hive decision as the answer to the head…
fix(stage): treat a recorded /hive decision as the answer to the head…
🐛 stage: a recorded /hive decision answers the head's requires_human …