Skip to content

🐛 adoption: dco-rehome never re-homes the inherited unsigned commit; fix kicks only cite CI so the adopted PR stays no-dco #14666

Closed

Description

@clubanderson

Symptom

When the hive adopts a contributor PR with reason=dco-rehome / lane_reason=dco-missing, the new hive-owned PR inherits the unsigned commit unchanged, and the hive's fix cycle never performs the re-home the PR body asks for. The adopted PR stays no-dco / stage/070-fixing (dco-missing) and can never merge.

Observed 2026-10-27 on hosted-available-oke-11-placeholder-r05x:

Compare #14608 (adopted from #14587): there the agent happened to rebase --signoff by itself ("re-pushed hive/adopt-14587 with the unsigned commit rebased --signoff") — the re-home is agent luck, not product behaviour.

Expected

  • dco-rehome adoption should do the re-home itself when it creates hive/adopt-N: git rebase --signoff (or cherry-pick -s) the inherited commits onto the base before pushing, keeping original authorship — the hive owns the branch, so it can.
  • If it cannot, the fix kick for an adopted head with no-dco must list "DCO: unsigned commit(s) " as a failing gate ahead of CI checks, and the FIX-BEFORE-NEW / reaper message should include it.
  • The dco-missing lane reason should block "fix is done" until the DCO label clears, not just until CI is green.

Related but distinct: #14605 covers follow-up commits pushed by agents lacking a sign-off (fixed by #14628 via prompt text). This issue is about the inherited unsigned commit on the adoption branch, which no prompt text fixes.

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 27, 2026
  2. github-actions commented on Oct 27, 2026

    @github-actions
    Contributor

    @clubanderson this issue was closed by @hivecommons-hive[bot] as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

  3. added a commit that references this issue on Oct 28, 2026
    bccbd25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions