Skip to content

Review backlog (correctness): PendingFixTTL has no config plumbing despite docs presenting it as a knob #14643

Closed

Description

@hivecommons-hive

Blocked on PR #14624. This finding came from reviewing PR #14624 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #14624.

PR: #14624 (#14624)
Perspective: correctness
Severity: low (P3)
Evidence: src/pkg/review/dispatch.go:231 (

// HeadMaxRetries caps how many times one review head's expired review of a
)
Finding: PendingFixTTL has no config plumbing despite docs presenting it as a knob

DispatchOptions.PendingFixTTL (src/pkg/review/dispatch.go:231) is only settable in code; unlike PendingTTL (src/pkg/config/review_dispatch.go:62, review.pending_ttl) no config field feeds it, so operators get only the 2h default while src/docs/labels-and-control-signals.md:788 cites PendingFixTTL as a tunable. Either wire review.pending_fix_ttl or describe it as a fixed 2h.

Fingerprint: eaba9f38e2e3b6a5bac3e0adab52747944bcdd1b81e22de534cf046cc1515106

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 27, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 27, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 27, 2026
  4. hivecommons-hive commented on Oct 27, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #14624 is no longer open. This issue is actionable again.

  5. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 27, 2026
  6. hivecommons-hive commented on Oct 27, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @Karibhou released (lease revoked).

  7. hivecommons-hive commented on Oct 27, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #14624 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.

  8. added 2 commits that reference this issue on Oct 27, 2026
    f472832
    e581c38
  9. added a commit that references this issue on Oct 27, 2026
    3abfa56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions