Skip to content

🐛 review-fix: follow-up commits pushed by hive/relay agents lack Signed-off-by, bouncing the PR to no-dco / 072 #14605

Closed

Description

@clubanderson

Symptom

Follow-up commits pushed by hive agents during the review-fix cycle lack the Signed-off-by trailer, so the PR immediately regresses to no-dco / stage/072-returned-to-contributor (or 070-fixing with reason dco-missing) and prow posts the DCO nag.

Observed today on hosted-available-oke-11-placeholder-r05x (build 6977027a):

PR first commit fix commit author
#14596 505f8f3e signed 7a764981 unsigned (16:24Z, pushed by scanner after [review-fix:hivecommons/hive#14596] kick at 12:17:48 ET) hivecommons-hive[bot]
#14587 465bc5ff signed 3b900acf unsigned Karibhou (clanker / relay hive)
#14592 b5ded176 signed 124bc48d unsigned Karibhou
hivecommons/rationguard#403 signed 22f4c69f pushed during 095 soak → 095 → 072 dco-missing regression Karibhou

In each case the hive then nudges the contributor to git rebase --signoff — for #14596 it is nudging itself. The 072 dwell is 24h, so these look healthy on the dashboard while they are actually waiting on a trailer.

Expected

  • The review-fix kick prompt (BuildFixPrompt) and the contributor relay fix path should require git commit -s / git rebase --signoff on every follow-up commit, and the gh-wrapper / push guard should refuse to push a hive-owned head whose new commits lack the trailer (a rebase --signoff before push is cheap).
  • Reusing the DCO check result: when a hive-owned head goes no-dco, route straight back into a bounded fix attempt ("add sign-off") rather than returning it to a contributor that is the hive itself.

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 27, 2026
  2. hivecommons-hive commented on Oct 27, 2026

    @hivecommons-hive
    Contributor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  3. clubanderson commented on Oct 27, 2026

    @clubanderson
    MemberAuthor

    /hive decision approve

    Direction for the fix (PR #14628 is on the right track):

    1. Prevention first. BuildFixPrompt and the relay fix path must instruct git commit -s / git rebase --signoff on every follow-up commit, and the push guard must refuse to push a hive-owned head whose new commits lack Signed-off-by — do a rebase --signoff before push instead of failing.
    2. Self-heal, don't bounce. When a hive-owned or relay-authored head goes no-dco, route into one bounded "add sign-off" fix attempt (070) rather than 072 returned-to-contributor. 072 is for humans; the hive nudging itself is a bug.
    3. Keep the 072 path for genuinely human-authored unsigned commits; don't rewrite anyone else's history.
    4. Add a regression test: fix commit without trailer → guard rewrites/refuses; hive-owned no-dco → 070 not 072.

    No config knob needed; this is always-on behaviour.

  4. github-actions commented on Oct 28, 2026

    @github-actions
    Contributor

    @clubanderson this issue was closed by @hivecommons-hive[bot] as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions