Skip to content

[security] agent_issue_decision_policy=resolve fails open on unclassified --needs-decision text #12969

Closed

Description

@clubanderson

Raised by the ci-maintainer security perspective on #12903 and deferred there as a cross-path policy change.

issueDecisionDowngrade (src/pkg/github/issue_request_watcher.go) parks only when decisionpolicy.Classify(text).Escalate is true. Classify returns the zero Classification{} (Escalate=false) when neither a risk term nor a non-risk engineering term matches, and EffectivePolicy defaults to resolve — so on a stock hive a Hive-authored --needs-decision whose wording misses both keyword lists is silently downgraded (not parked) and gets a Decision taken by hive footer instead of reaching the owner. This applies equally to the issue, label (#12852) and, since #12903, comment paths.

Proposed: fail closed on every path — downgrade only on a positive engineering classification (decisionpolicy.ResolvesWithoutHuman(text), already defined), park otherwise; add tests with neutral wording (e.g. "Agents do not edit repository settings; the owner runs: gh api --method PUT …") asserting the park still happens under resolve. Land on v5, forward-merge to v6.

Risk: security posture

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 19, 2026
  2. hivecommons-hive commented on Oct 19, 2026

    @hivecommons-hive
    Contributor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  3. added a commit that references this issue on Oct 19, 2026
  4. github-actions commented on Oct 19, 2026

    @github-actions
    Contributor

    @clubanderson this issue was closed by @hivecommons-hive[bot] as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.stage/stalledIn its current stage longer than expected

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions