Skip to content

🐛 Contributor-lane auto-merge ignores the operator-set registry tier; trusted contributors skip with no-linked-issue / no-claim #12166

Closed

Description

@clubanderson

Summary

The automerge contributor lane (src/pkg/github/automerge/automerge_contributor_lane.go, introduced by #12051) only merges a non-App-authored PR when the PR closes an issue (closing keyword) whose App-authored hive:claim marker says kind=contributor who=<author> hive=<this hive> tier=<require_tiers> verified=true. The tier is read only from the claim marker; the operator-set trust tier in the hive's contributor registry (Contribute → Admin → trust tier) is never consulted.

So an operator marking a contributor trusted has no effect on auto-merge unless every PR that contributor opens closes a relay-claimed issue.

Observed on hive's own hive

Contributor mrbobbytables is trusted in the contributor registry, yet the sweep skipped:

Both PRs were CI-green and reviewer-approved; both waited for a manual /lgtm the maintainer did not want to give ("if I have them trusted I don't want to be bothered").

Expected

If the PR author is present in the contributor registry with a tier in auto_merge.contributor_lane.require_tiers (default trusted, merger), the lane should treat the claim/tier requirement as satisfied without a linked issue or hive:claim marker. All other gates stay (author_association, workflow/test diff fences, CI green, reviewer verdict, soak, labels, human-merge paths). The admit path should be logged distinctly (e.g. contributor-lane:registry-trusted) so operators can tell a registry-admitted merge from a marker-admitted one, and the existing marker path should stay intact for contributors not in the registry.

Config-gate it following the existing auto_merge.contributor_lane.* pattern (registry_tiers_sufficient, default true).

Refs #12051.

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 15, 2026
  2. added
    🐝 covered by PRHive verified that an open PR references or claims this issue; still actionable until confirmed
    on Oct 15, 2026
  3. github-actions commented on Oct 15, 2026

    @github-actions
    Contributor

    @clubanderson this issue was closed by @hivecommons-hive[bot] as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinghelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.🐝 covered by PRHive verified that an open PR references or claims this issue; still actionable until confirmed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions