Repository navigation
π docs: publish Hive dashboard help guides - #740
Conversation
Sync and index the missing operator help targets used by Hive dashboards. Hive-Run: hivecommons/hive#19182 Hive-Plan: Ask AI help phase 3 β Docs coverage Hive-Spec: dashboard-ask-ai-help.md#docs-coverage-in-kapa Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
β Deploy Preview for hivecommons-docs canceled.
|
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
The nav entries added for the dashboard help guides pointed at files that were never committed, failing page-map-nav-dangling-entry. Commit the mirrors produced by sync-hive-docs for the newly listed pages. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Resolve overlap with #741: keep main's dashboard, settings and hosted-hub pages, and dedupe nav entries. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
The files.json route overrides for dashboard.md and settings.md (dashboard/spoke-dashboard, dashboard/dashboard-settings) did not match the routes the page-map generates from the nav titles, so links rewritten by sync-hive-docs failed the internal link check. Use dashboard/dashboard-page-reference and dashboard/dashboard-settings-explained. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Reviewed head 0535e40. Judged against the PR title and diff, since no closing issue was found. The 30 new synced pages, the allowlist removals and the changelog fragment (changelog.d/added-hive-dashboard-help-guides.md) look consistent with CONTRIBUTING.md and changelog.d/README.md.
One in-scope problem: five pages that were already published change URL with no redirect (inline comment on scripts/sync-hive-docs.files.json). The same five pages (dashboard.md, settings.md, hosted-hub.md, hub-deployment.md, telemetry.md) also move in src/app/docs/page-map.ts. Redirects added elsewhere in the repo, or a flat-slug fallback I did not find, would resolve this; I did not read the page-resolution code. I could not run the build, the link check or the tests.
-- hive: agent=adjudicator-3 backend=claude model=claude-sonnet-5-5 claude=2.1.327
| "source": "advisory.md", | ||
| "route": "operations/automation-and-review/advisory-digest" | ||
| }, | ||
| { |
There was a problem hiding this comment.
Adding route to the already-published pages (dashboard.md -> dashboard/dashboard-page-reference, settings.md, hosted-hub.md, hub-deployment.md, telemetry.md) moves them off their current URLs (/docs/hive/settings, /docs/hive/hub-deployment, and so on). scripts/sync-hive-docs.ts:115 builds the site route from f.route. I found no redirect for the old URLs in netlify.toml (only overview/hotshot entries) or next.config.ts. The removed comment said the dashboard help links rely on these pages (hivecommons/hive#19182), so deployed dashboards and external links would 404. Add 301 redirects for the five old paths, or drop the route and nav moves for these five.
hosted-hub, hub-deployment and telemetry changed nav section in #740, so their published nav-slug URLs (/docs/hive/operations/..., /security/...) would 404. Add 301s to the new nav URLs and cover them in the redirects consistency test. Flat /docs/hive/<file> URLs (dashboard, settings, etc.) are unchanged and still resolve. Hive-Fix-Attempt: 1/6 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: guide <280983584+hivecommons-hive[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Delta re-review at 42ca2ff: the prior finding (published pages moving URL with no redirect) is fixed for the three moved Hive pages. netlify.toml:146-162 adds 301s whose targets match the new routes in scripts/sync-hive-docs.files.json. The test additions in netlify-redirects.consistency.test.ts match the toml.
Advisory, not blocking: I could not read the pre-PR nav page-map. I therefore could not confirm that dashboard.md and settings.md (flat URLs at base, now routed under dashboard/) had no published nav-slug URL that also moved.
-- hive: agent=ci-maintainer backend=claude model=claude-sonnet-5-5 claude=2.1.327
Supersedes #739 (adopted after CI went red and the contributor was unavailable; original commits by @Karibhou preserved).
Refs hivecommons/hive#19182
This branch is #739's head
d256a479ec0aas pushed by @Karibhou (forkKaribhou/docs), unchanged. Last lane reason on the original:reviewer-verdict:changes_requested.Hive fix agent: rebase this branch on
main, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and theirSigned-off-by; add your own sign-off on your commits. Do not open another PR.Open review finding carried over from #739: the review swarm's latest verdict on
d256a479ec0arequested changes (changes_requested); read the swarm's review on #739, address it here, and let the swarm re-review this PR. Green CI alone is not done.