Repository navigation
🐛 netlify: move nps.test.ts out of the functions directory so deploys succeed - #224
Conversation
Netlify treats every file in netlify/functions as a deployable function and rejects the name 'nps.test' (dots are not allowed), which has failed every production deploy since #202 landed. Move the test beside the relay tests and point its imports back at the function. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
c7e5fef to
128f9ac
Compare
✅ Deploy Preview for hivecommons-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Admin-merging ahead of GitHub Actions: runners have been queued 13+ min with 0 in progress (repo-wide backlog). Netlify deploy-preview is green and serves /docs/hive/running-at-level-6 with 200; vitest passed locally (46/46). This unblocks production, which has been frozen on main@8212db7 since Oct 4. |
1 participant
Problem
Every Netlify deploy (preview and production) has failed since #202 with:
Netlify treats every file in
netlify/functions/as a function;nps.test.tsyields the illegal namenps.test. Production is frozen onmain@8212db7(Oct 4), so #202–#223 (deps bumps, integrations refresh, ACMM wording, Level 6 guide, knowledge MCP endpoint) are not live.Fix
Move
netlify/functions/nps.test.ts→netlify/nps-relay/nps.test.ts(besiderelay.test.ts) and repoint its imports. No behaviour change; the functions dir now contains onlynps.mts.Verification
npx vitest run netlify✅ (46 tests)netlify/hivecommons-docs/deploy-previewcheck on this PR should go green for the first time since refactor: remove unused Loader, radar and Mermaid modules #206.