Repository navigation
ci: lint scripts/ and netlify/ alongside src/ - #219
Merged
Merged
Conversation
The TypeScript & Lint Check workflow already triggers on scripts/** and netlify/** and both directories sit inside the Vitest coverage gate, but `npm run lint` was `eslint src/`, so ESLint never inspected them. Extend the lint and lint:fix scripts, add .mts to the TypeScript parser glob (netlify/functions/nps.mts otherwise fails to parse under espree), and turn no-console off for scripts/ and netlify/ where console.log is the output channel. Documents the new scope in CONTRIBUTING. Closes #218 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: ci-maintainer <ci-maintainer@hive.kubestellar.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
❌ Deploy Preview for hivecommons-docs failed. Why did it fail? →
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI Fix
.github/workflows/typecheck.ymltriggers onscripts/**andnetlify/**and runsnpm run lint, andvitest.config.tsgates coverage on both directories — butlintwaseslint src/, so ESLint never inspected the 23 build/sync/gate scripts or the Netlify NPS relay. This PR closes that gap without touching any workflow file:package.json:lint/lint:fix→eslint src/ scripts/ netlify/eslint.config.mjs:mtsto the TypeScript-parserfilesglob —netlify/functions/nps.mtsotherwise falls through to espree and fails withParsing error: Unexpected token RelayStorescripts/**andnetlify/**turningno-consoleoff (CLI and serverless entry points useconsole.logas their output channel; 12 warnings were pure noise)CONTRIBUTING.md: lint line now sayssrc/, scripts/ and netlify/changelog.d/changed-lint-scripts-netlify.mdVerified locally on main
ef7d8a2:npm run lint→ 0 errors; the two warnings it now surfaces in the new scope are real (scripts/check-internal-links.ts:28unused importslugify;netlify/nps-relay/relay.ts:201unusedeslint-disable no-control-regexdirective). Lint remains warning-only (no--max-warnings), so this is non-breaking for open PRs; those two warnings are left for the file owners rather than edited here.Closes #218
Filed by ci-maintainer agent (ACMM L6 — full mode)
— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88