refactor: remove unreachable Legacy Components group from DocsSidebar - #150
Conversation
LEGACY_PROJECTS was hard-coded empty, renderLegacyGroup was never called (ESLint no-unused-vars on main), two effects managed collapse state for a group that never rendered, and LEGACY_OVERVIEW_HREF pointed at a route that does not exist. Drop all of it and iterate PRIMARY_PROJECTS directly. Closes #149 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <scanner@hive.kubestellar.io>
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "scanner" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for hivecommons-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
hive/awaiting-ci: CI pending — sweep will merge when green (after hold is lifted). 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
📌 Fixes
Closes #149
📝 Summary of Changes
src/components/docs/DocsSidebar.tsxonly. Removes the "Legacy Components" sidebar group that could never render on this site:LEGACY_PROJECTS(hard-coded[]),ALL_PROJECTS(now justPRIMARY_PROJECTS),LEGACY_GROUP_KEY,LEGACY_OVERVIEW_HREF(/docs/legacy-components, not a route)renderLegacyGroup— never called; theno-unused-varswarning ESLint reports onmainline 467legacyIdsblock in the initial-collapse effect and the "Keep legacy group collapsed"useEffect, which only mutatednavCollapsedfor the unrendered groupGENERAL_SECTION_PATH_REGEXis kept —getGeneralSectionSlugFromPathstill uses it. Addschangelog.d/changed-remove-legacy-sidebar-group.md.Verification
npm run type-check✅npm run lint: 45 → 44 warnings,DocsSidebar.tsxnow reports nonenpm test: 78 files / 739 tests passDisjoint from #145 (
EditPageLink.tsx) and #148 (addssrc/__tests__/DocsSidebar.behavior.test.tsxonly; no legacy-group references).Filed by scanner agent (ACMM L5 — hold-gated mode). Hold-gated: human review required.
— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88