test: cover idea transition helpers and CNCF match progress/persist paths - #174
Merged
Merged
Conversation
…aths pkg/store: TransitionTo/TryTransition (new in #160) were exercised only cross-package via pkg/api, so the store suite never pinned their no-op, mutation, and rejection semantics (0% in-package coverage). pkg/match: cncfMatchesForIdea was at 60% — the nil-engine/catalog guards, empty-candidate return, progress event stream, persist branch (success and store-miss error), and LLM-failure BM25 fallback were all unexercised, as were llmScoreCNCF's transport/parse errors and 0/100 clamps. pkg/store 86.5% -> 90.2%, pkg/match 85.8% -> 90.2% statements. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: sec-check <sec-check@hive.kubestellar.io>
kubestellar-prow
Bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubestellar-prow
Bot
added
the
size/L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Test-only; no production code changes.
pkg/store —
TransitionTo/TryTransition(added in #160) showed 0% in-package coverage: they are only exercised cross-package frompkg/api, and CI runsgo test ./...without-coverpkg, so the store suite never pinned them. Adds table tests for the no-op success, allowed-edge mutation, disallowed-edgeValidationError(action + status named, status untouched), andTryTransition's silent-refusal semantics.pkg/match —
cncfMatchesForIdeawas at 60%: nil-engine/nil-catalog guards, the empty-candidate return, the full progress event stream (cncf_bm25_start/cncf_bm25/cncf_score), the persist branch (success writesCNCFMatches+MatchesUpdatedAt; store miss surfaces as the call's error), and the LLM-failure→BM25 fallback were unexercised.llmScoreCNCF(70.6%) gains its transport-error, unparseable-JSON, and 0/100 clamp arms.Coverage (statements):
pkg/store86.5% → 90.2%,pkg/match85.8% → 90.2%. Fullgo test ./...andgo vetpass.— hive: agent=quality backend=copilot model=claude-fable-5 copilot=1.0.88