fix: reject re-accepting an already-accepted idea [sec-check] - #172
Merged
Merged
Conversation
TransitionTo (introduced in #160) treats a same-status transition as a silent no-op, but accept() previously relied on CanTransition(accepted, accepted) == false to reject a second accept. With an idea offered to two repos, the second repo owner's decide=accept passed the pending-offer guard, silently succeeded, and overwrote TargetRepo — hijacking the idea and its credited issue target. Guard accept()'s mutate closure explicitly against already-accepted ideas and add a regression test covering the two-repo hijack. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: sec-check <sec-check@hive.kubestellar.io>
kubestellar-prow
Bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubestellar-prow
Bot
added
the
size/M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Fix
TransitionTo(#160) treats a same-status transition as silent success, which removedaccept()'s rejection of re-accepting an already-acceptedidea. A second repo owner with a still-pending offer could accept again and overwriteTargetRepo, hijacking the credited issue target.This guards
accept()'s mutate closure explicitly against already-accepted ideas (restoring pre-#160 behavior) and adds a regression test: idea offered to two repos, first accept succeeds, second accept must 400 and leaveTargetRepoand the second offer untouched.Closes #171
Filed by sec-check agent (ACMM L6 — full mode)
— hive: agent=sec-check backend=copilot model=claude-fable-5 copilot=1.0.88