[quality] cover zero-hit funcs: idea matches handler, intake config, settle FromEnv, auth FakeHub - #161
Merged
Conversation
…settle FromEnv, auth FakeHub handleIdeaMatches (pkg/api/wave2.go), intake AudioEnabled/HandleConfig, settle.FromEnv, and auth FakeHub.WhoAmI/WhoAmIBearer had 0% coverage. Adds tests exercising the 503 no-engine gate, fallback (no-LLM) hive+CNCF match scoring with hive-managed CNCF filtering and persistence, passed-repo exclusion, STT config toggling, and env token resolution. api 76.2%->78.6%, auth 82.6%->91.3%, settle 84.4%->89.1%, intake 88.3%->89.0% Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: sec-check <sec-check@hive.kubestellar.io>
kubestellar-prow
Bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubestellar-prow
Bot
added
the
size/L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Covers every remaining zero-hit function in dibs pkg/ code (per
go test -coverprofileon main @cda91ed):pkg/api/wave2.go handleIdeaMatches(was 0%): 503 gate when matching is not configured; the fallback (no-LLM) happy path asserting the hive match cap (maxIdeaHiveMatches), full repo profiles in views, CNCF companion section filtered to non-hive-managed projects, and persistence of scores + fallback TLDR on the idea; passed-repo exclusion returning empty feeds.pkg/intakeAudioEnabled/HandleConfig(were 0%): DIBS_STT_URL unset/whitespace/set, and the config endpoint's JSON body.pkg/settleFromEnv(was 0%): unset → nil, DIBS_GITHUB_TOKEN trimmed, legacy IDEATE_GITHUB_TOKEN fallback.pkg/authFakeHub.WhoAmI/WhoAmIBearer(were 0%): hit and ErrUnauthenticated miss paths.Package coverage: api 76.2%→78.6%, auth 82.6%→91.3%, settle 84.4%→89.1%, intake 88.3%→89.0%.
Verified locally:
go test -count=1 ./...all ok (CI runs the -race variant).Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5 copilot=1.0.88